aboutsummaryrefslogtreecommitdiff
path: root/src/cmd
diff options
context:
space:
mode:
authorMark Ryan <markdryan@rivosinc.com>2023-11-07 10:09:49 +0100
committerJoel Sing <joel@sing.id.au>2024-01-24 07:25:25 +0000
commitb4e7d630bc6fbf654a20a4bebda94a8150811bea (patch)
tree496a37c6588cbe32311b8534619138e7cf0ef345 /src/cmd
parentb3acaa8230e95c232a6f5c30eb7619a0c859ab16 (diff)
downloadgo-b4e7d630bc6fbf654a20a4bebda94a8150811bea.tar.xz
cmd/go: add GORISCV64 environment variable
The variable represents the RISC-V user-mode application profile for which to compile. Valid values are rva20u64 (the default) and rva22u64. Setting GORISCV64=rva20u64 defines the riscv64.rva20u64 build tag, sets the internal variable buildcfg.GORISCV64 to 20 and defines the macro GORISCV64_rva20u64 for use in assembly language code. Setting GORISCV64=rva22u64 defines the riscv64.rva20u64 and riscv64.rva22u64 build tags, sets the internal variable buildcfg.GORISCV64 to 22 and defines the macro GORISCV64_rva22u64 for use in assembly language code. This patch only provides a mechanism for the compiler and hand-coded assembly language functions to take advantage of the RISC-V extensions mandated by the application profiles. Further patches will be required to get the compiler/assembler and assembly language functions to actually generate and use these extensions. Fixes #61476 Change-Id: I9195ae6ee71703cd2112160e89157ab63b8391af Reviewed-on: https://go-review.googlesource.com/c/go/+/541135 Reviewed-by: M Zhuo <mengzhuo1203@gmail.com> Reviewed-by: Joel Sing <joel@sing.id.au> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Wang Yaduo <wangyaduo@linux.alibaba.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: M Zhuo <mengzhuo1203@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/cmd')
-rw-r--r--src/cmd/dist/build.go15
-rw-r--r--src/cmd/dist/buildruntime.go1
-rw-r--r--src/cmd/go/alldocs.go9
-rw-r--r--src/cmd/go/internal/cfg/cfg.go17
-rw-r--r--src/cmd/go/internal/help/helpdoc.go9
-rw-r--r--src/cmd/go/internal/work/gc.go5
-rw-r--r--src/cmd/go/testdata/script/tooltags.txt20
-rw-r--r--src/cmd/internal/testdir/testdir_test.go2
8 files changed, 68 insertions, 10 deletions
diff --git a/src/cmd/dist/build.go b/src/cmd/dist/build.go
index 32e59b446a..96199bcbfa 100644
--- a/src/cmd/dist/build.go
+++ b/src/cmd/dist/build.go
@@ -38,6 +38,7 @@ var (
gomips string
gomips64 string
goppc64 string
+ goriscv64 string
goroot string
goroot_final string
goextlinkenabled string
@@ -177,6 +178,12 @@ func xinit() {
}
goppc64 = b
+ b = os.Getenv("GORISCV64")
+ if b == "" {
+ b = "rva20u64"
+ }
+ goriscv64 = b
+
if p := pathf("%s/src/all.bash", goroot); !isfile(p) {
fatalf("$GOROOT is not set correctly or not exported\n"+
"\tGOROOT=%s\n"+
@@ -236,6 +243,7 @@ func xinit() {
os.Setenv("GOMIPS", gomips)
os.Setenv("GOMIPS64", gomips64)
os.Setenv("GOPPC64", goppc64)
+ os.Setenv("GORISCV64", goriscv64)
os.Setenv("GOROOT", goroot)
os.Setenv("GOROOT_FINAL", goroot_final)
@@ -891,6 +899,10 @@ func runInstall(pkg string, ch chan struct{}) {
asmArgs = append(asmArgs, "-D", "GOPPC64_power8")
}
}
+ if goarch == "riscv64" {
+ // Define GORISCV64_value from goriscv64
+ asmArgs = append(asmArgs, "-D", "GORISCV64_"+goriscv64)
+ }
goasmh := pathf("%s/go_asm.h", workdir)
// Collect symabis from assembly code.
@@ -1236,6 +1248,9 @@ func cmdenv() {
if goarch == "ppc64" || goarch == "ppc64le" {
xprintf(format, "GOPPC64", goppc64)
}
+ if goarch == "riscv64" {
+ xprintf(format, "GORISCV64", goriscv64)
+ }
xprintf(format, "GOWORK", "off")
if *path {
diff --git a/src/cmd/dist/buildruntime.go b/src/cmd/dist/buildruntime.go
index 1de78f0fdb..b041183bdf 100644
--- a/src/cmd/dist/buildruntime.go
+++ b/src/cmd/dist/buildruntime.go
@@ -57,6 +57,7 @@ func mkbuildcfg(file string) {
fmt.Fprintf(&buf, "const defaultGOMIPS = `%s`\n", gomips)
fmt.Fprintf(&buf, "const defaultGOMIPS64 = `%s`\n", gomips64)
fmt.Fprintf(&buf, "const defaultGOPPC64 = `%s`\n", goppc64)
+ fmt.Fprintf(&buf, "const defaultGORISCV64 = `%s`\n", goriscv64)
fmt.Fprintf(&buf, "const defaultGOEXPERIMENT = `%s`\n", goexperiment)
fmt.Fprintf(&buf, "const defaultGO_EXTLINK_ENABLED = `%s`\n", goextlinkenabled)
fmt.Fprintf(&buf, "const defaultGO_LDSO = `%s`\n", defaultldso)
diff --git a/src/cmd/go/alldocs.go b/src/cmd/go/alldocs.go
index e61e865c84..05e42a6d31 100644
--- a/src/cmd/go/alldocs.go
+++ b/src/cmd/go/alldocs.go
@@ -2001,10 +2001,13 @@
// ppc64.power8, ppc64.power9, and ppc64.power10
// (or ppc64le.power8, ppc64le.power9, and ppc64le.power10)
// feature build tags.
+// - For GOARCH=riscv64,
+// GORISCV64=rva20u64 and rva22u64 correspond to the riscv64.rva20u64
+// and riscv64.rva22u64 build tags.
// - For GOARCH=wasm, GOWASM=satconv and signext
// correspond to the wasm.satconv and wasm.signext feature build tags.
//
-// For GOARCH=amd64, arm, ppc64, and ppc64le, a particular feature level
+// For GOARCH=amd64, arm, ppc64, ppc64le, and riscv64, a particular feature level
// sets the feature build tags for all previous levels as well.
// For example, GOAMD64=v2 sets the amd64.v1 and amd64.v2 feature flags.
// This ensures that code making use of v2 features continues to compile
@@ -2300,6 +2303,10 @@
// GOPPC64
// For GOARCH=ppc64{,le}, the target ISA (Instruction Set Architecture).
// Valid values are power8 (default), power9, power10.
+// GORISCV64
+// For GOARCH=riscv64, the RISC-V user-mode application profile for which
+// to compile. Valid values are rva20u64 (default), rva22u64.
+// See https://github.com/riscv/riscv-profiles/blob/main/profiles.adoc
// GOWASM
// For GOARCH=wasm, comma-separated list of experimental WebAssembly features to use.
// Valid values are satconv, signext.
diff --git a/src/cmd/go/internal/cfg/cfg.go b/src/cmd/go/internal/cfg/cfg.go
index a8daa2dfc3..948bceab32 100644
--- a/src/cmd/go/internal/cfg/cfg.go
+++ b/src/cmd/go/internal/cfg/cfg.go
@@ -408,13 +408,14 @@ var (
GOMODCACHE = envOr("GOMODCACHE", gopathDir("pkg/mod"))
// Used in envcmd.MkEnv and build ID computations.
- GOARM = envOr("GOARM", fmt.Sprint(buildcfg.GOARM))
- GO386 = envOr("GO386", buildcfg.GO386)
- GOAMD64 = envOr("GOAMD64", fmt.Sprintf("%s%d", "v", buildcfg.GOAMD64))
- GOMIPS = envOr("GOMIPS", buildcfg.GOMIPS)
- GOMIPS64 = envOr("GOMIPS64", buildcfg.GOMIPS64)
- GOPPC64 = envOr("GOPPC64", fmt.Sprintf("%s%d", "power", buildcfg.GOPPC64))
- GOWASM = envOr("GOWASM", fmt.Sprint(buildcfg.GOWASM))
+ GOARM = envOr("GOARM", fmt.Sprint(buildcfg.GOARM))
+ GO386 = envOr("GO386", buildcfg.GO386)
+ GOAMD64 = envOr("GOAMD64", fmt.Sprintf("%s%d", "v", buildcfg.GOAMD64))
+ GOMIPS = envOr("GOMIPS", buildcfg.GOMIPS)
+ GOMIPS64 = envOr("GOMIPS64", buildcfg.GOMIPS64)
+ GOPPC64 = envOr("GOPPC64", fmt.Sprintf("%s%d", "power", buildcfg.GOPPC64))
+ GORISCV64 = envOr("GORISCV64", fmt.Sprintf("rva%du64", buildcfg.GORISCV64))
+ GOWASM = envOr("GOWASM", fmt.Sprint(buildcfg.GOWASM))
GOPROXY = envOr("GOPROXY", "")
GOSUMDB = envOr("GOSUMDB", "")
@@ -445,6 +446,8 @@ func GetArchEnv() (key, val string) {
return "GOMIPS64", GOMIPS64
case "ppc64", "ppc64le":
return "GOPPC64", GOPPC64
+ case "riscv64":
+ return "GORISCV64", GORISCV64
case "wasm":
return "GOWASM", GOWASM
}
diff --git a/src/cmd/go/internal/help/helpdoc.go b/src/cmd/go/internal/help/helpdoc.go
index c5d1e2af16..a53e078d79 100644
--- a/src/cmd/go/internal/help/helpdoc.go
+++ b/src/cmd/go/internal/help/helpdoc.go
@@ -619,6 +619,10 @@ Architecture-specific environment variables:
GOPPC64
For GOARCH=ppc64{,le}, the target ISA (Instruction Set Architecture).
Valid values are power8 (default), power9, power10.
+ GORISCV64
+ For GOARCH=riscv64, the RISC-V user-mode application profile for which
+ to compile. Valid values are rva20u64 (default), rva22u64.
+ See https://github.com/riscv/riscv-profiles/blob/main/profiles.adoc
GOWASM
For GOARCH=wasm, comma-separated list of experimental WebAssembly features to use.
Valid values are satconv, signext.
@@ -907,10 +911,13 @@ The defined architecture feature build tags are:
ppc64.power8, ppc64.power9, and ppc64.power10
(or ppc64le.power8, ppc64le.power9, and ppc64le.power10)
feature build tags.
+ - For GOARCH=riscv64,
+ GORISCV64=rva20u64 and rva22u64 correspond to the riscv64.rva20u64
+ and riscv64.rva22u64 build tags.
- For GOARCH=wasm, GOWASM=satconv and signext
correspond to the wasm.satconv and wasm.signext feature build tags.
-For GOARCH=amd64, arm, ppc64, and ppc64le, a particular feature level
+For GOARCH=amd64, arm, ppc64, ppc64le, and riscv64, a particular feature level
sets the feature build tags for all previous levels as well.
For example, GOAMD64=v2 sets the amd64.v1 and amd64.v2 feature flags.
This ensures that code making use of v2 features continues to compile
diff --git a/src/cmd/go/internal/work/gc.go b/src/cmd/go/internal/work/gc.go
index e2a5456bde..09ea8259e0 100644
--- a/src/cmd/go/internal/work/gc.go
+++ b/src/cmd/go/internal/work/gc.go
@@ -361,6 +361,11 @@ func asmArgs(a *Action, p *load.Package) []any {
}
}
+ if cfg.Goarch == "riscv64" {
+ // Define GORISCV64_value from cfg.GORISCV64.
+ args = append(args, "-D", "GORISCV64_"+cfg.GORISCV64)
+ }
+
if cfg.Goarch == "arm" {
// Define GOARM_value from cfg.GOARM.
switch cfg.GOARM {
diff --git a/src/cmd/go/testdata/script/tooltags.txt b/src/cmd/go/testdata/script/tooltags.txt
index 27068eebae..1f6f54563c 100644
--- a/src/cmd/go/testdata/script/tooltags.txt
+++ b/src/cmd/go/testdata/script/tooltags.txt
@@ -40,6 +40,26 @@ env GOPPC64=power10
go list -f '{{context.ToolTags}}'
stdout 'ppc64le.power8 ppc64le.power9 ppc64le.power10'
+env GOARCH=riscv64
+env GORISCV64=rva20u64
+go list -f '{{context.ToolTags}}'
+stdout 'riscv64.rva20u64'
+
+env GOARCH=riscv64
+env GORISCV64=rva22u64
+go list -f '{{context.ToolTags}}'
+stdout 'riscv64.rva20u64 riscv64.rva22u64'
+
+env GOARCH=riscv64
+env GORISCV64=rva22
+! go list -f '{{context.ToolTags}}'
+stderr 'go: invalid GORISCV64: must be rva20u64, rva22u64'
+
+env GOARCH=riscv64
+env GORISCV64=
+go list -f '{{context.ToolTags}}'
+stdout 'riscv64.rva20u64'
+
env GOARCH=386
env GO386=sse2
go list -f '{{context.ToolTags}}'
diff --git a/src/cmd/internal/testdir/testdir_test.go b/src/cmd/internal/testdir/testdir_test.go
index 0fb56e6c78..a26733d856 100644
--- a/src/cmd/internal/testdir/testdir_test.go
+++ b/src/cmd/internal/testdir/testdir_test.go
@@ -1468,7 +1468,7 @@ var (
"ppc64x": {}, // A pseudo-arch representing both ppc64 and ppc64le
"s390x": {},
"wasm": {},
- "riscv64": {},
+ "riscv64": {"GORISCV64", "rva20u64", "rva22u64"},
}
)