diff options
| author | Russ Cox <rsc@golang.org> | 2014-08-07 12:33:06 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2014-08-07 12:33:06 -0400 |
| commit | 08033f9816e1e33092c93c050dc34514d8e3e926 (patch) | |
| tree | e7442db7fd5cbf52364c7617d437f30374e1117e /src/cmd/nm/nm_test.go | |
| parent | fad69a7b77a7996b0308bdbcd559b78b32046bb3 (diff) | |
| download | go-08033f9816e1e33092c93c050dc34514d8e3e926.tar.xz | |
cmd/addr2line, cmd/nm: factor object reading into cmd/internal/objfile
To do in another CL: make cmd/objdump use cmd/internal/objfile too.
There is a package placement decision in this CL:
cmd/internal/objfile instead of internal/objfile.
I chose to put internal under cmd to make clear (and enforce)
that no standard library packages should use this
(it's a bit dependency-heavy).
LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/123910043
Diffstat (limited to 'src/cmd/nm/nm_test.go')
| -rw-r--r-- | src/cmd/nm/nm_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/nm/nm_test.go b/src/cmd/nm/nm_test.go index 74773877f3..f447e8e491 100644 --- a/src/cmd/nm/nm_test.go +++ b/src/cmd/nm/nm_test.go @@ -77,7 +77,7 @@ func TestNM(t *testing.T) { "elf/testdata/gcc-amd64-linux-exec", "macho/testdata/gcc-386-darwin-exec", "macho/testdata/gcc-amd64-darwin-exec", - "pe/testdata/gcc-amd64-mingw-exec", + // "pe/testdata/gcc-amd64-mingw-exec", // no symbols! "pe/testdata/gcc-386-mingw-exec", "plan9obj/testdata/amd64-plan9-exec", "plan9obj/testdata/386-plan9-exec", @@ -87,7 +87,7 @@ func TestNM(t *testing.T) { cmd := exec.Command(testnmpath, exepath) out, err := cmd.CombinedOutput() if err != nil { - t.Fatalf("go tool nm %v: %v\n%s", exepath, err, string(out)) + t.Errorf("go tool nm %v: %v\n%s", exepath, err, string(out)) } } |