diff options
| author | Quim Muntal <quimmuntal@gmail.com> | 2023-01-26 07:48:04 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-01-26 15:41:28 +0000 |
| commit | a9780d8dfd38ae0b11b093cabe5b8086f202c3cd (patch) | |
| tree | 3c83cedfbf342f4a136d9e7610f9a0ecd040370b /src/cmd/internal | |
| parent | 4df10fba1687a6d4f51d7238a403f8f2298f6a16 (diff) | |
| download | go-a9780d8dfd38ae0b11b093cabe5b8086f202c3cd.tar.xz | |
Revert "runtime: use explicit NOFRAME on darwin/amd64"
This reverts CL 460235.
Reason for revert: This breaks darwin 10 and 11
Change-Id: I3c663ebe3b77eba45a006a3ebec5cabe667faa9e
Reviewed-on: https://go-review.googlesource.com/c/go/+/463635
Auto-Submit: Quim Muntal <quimmuntal@gmail.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Diffstat (limited to 'src/cmd/internal')
| -rw-r--r-- | src/cmd/internal/obj/x86/obj6.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/internal/obj/x86/obj6.go b/src/cmd/internal/obj/x86/obj6.go index 4a9b3b88ec..aa4cc225c6 100644 --- a/src/cmd/internal/obj/x86/obj6.go +++ b/src/cmd/internal/obj/x86/obj6.go @@ -614,14 +614,14 @@ func preprocess(ctxt *obj.Link, cursym *obj.LSym, newprog obj.ProgAlloc) { var bpsize int if ctxt.Arch.Family == sys.AMD64 && !p.From.Sym.NoFrame() && // (1) below - !(autoffset == 0 && p.From.Sym.NoSplit() && ctxt.Headtype != objabi.Hwindows && ctxt.Headtype != objabi.Hdarwin) && // (2) below + !(autoffset == 0 && p.From.Sym.NoSplit() && ctxt.Headtype != objabi.Hwindows) && // (2) below !(autoffset == 0 && !hasCall) { // (3) below // Make room to save a base pointer. // There are 2 cases we must avoid: // 1) If noframe is set (which we do for functions which tail call). // 2) Scary runtime internals which would be all messed up by frame pointers. // We detect these using a heuristic: frameless nosplit functions. - // Windows and Darwin do not use this heuristic anymore. + // Windows does not use this heuristic anymore. // TODO: Maybe someday we label them all with NOFRAME and get rid of this heuristic. // For performance, we also want to avoid: // 3) Frameless leaf functions |