diff options
| author | Neal Patel <nealpatel@google.com> | 2026-01-27 22:37:38 +0000 |
|---|---|---|
| committer | Neal Patel <nealpatel@google.com> | 2026-01-30 07:54:05 -0800 |
| commit | afae85307206cb56851c31652bd9ae45ba60c800 (patch) | |
| tree | cc48cf4eef59e1ac7bf93724924f4c8c3c25f712 /src/cmd/internal/script/engine.go | |
| parent | 5aa006dee0fae19cea85843cb0c83636a3181e0e (diff) | |
| download | go-afae85307206cb56851c31652bd9ae45ba60c800.tar.xz | |
cmd/go,crypto/mlkem,crypto/x509,encoding/ascii85: clean up tautological/impossible nil conditions
Change-Id: I3cdc599ebc93f5c9be5645e7ef7ce167242d9c1b
Reviewed-on: https://go-review.googlesource.com/c/go/+/739800
Reviewed-by: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'src/cmd/internal/script/engine.go')
| -rw-r--r-- | src/cmd/internal/script/engine.go | 32 |
1 files changed, 15 insertions, 17 deletions
diff --git a/src/cmd/internal/script/engine.go b/src/cmd/internal/script/engine.go index 05b9433d3e..9480741c10 100644 --- a/src/cmd/internal/script/engine.go +++ b/src/cmd/internal/script/engine.go @@ -580,23 +580,21 @@ func (e *Engine) runCommand(s *State, cmd *command, impl Cmd) error { return nil } - if wait != nil { - stdout, stderr, waitErr := wait(s) - s.stdout = stdout - s.stderr = stderr - if stdout != "" { - s.Logf("[stdout]\n%s", stdout) - } - if stderr != "" { - s.Logf("[stderr]\n%s", stderr) - } - if cmdErr := checkStatus(cmd, waitErr); cmdErr != nil { - return cmdErr - } - if waitErr != nil { - // waitErr was expected (by cmd.want), so log it instead of returning it. - s.Logf("[%v]\n", waitErr) - } + stdout, stderr, waitErr := wait(s) + s.stdout = stdout + s.stderr = stderr + if stdout != "" { + s.Logf("[stdout]\n%s", stdout) + } + if stderr != "" { + s.Logf("[stderr]\n%s", stderr) + } + if cmdErr := checkStatus(cmd, waitErr); cmdErr != nil { + return cmdErr + } + if waitErr != nil { + // waitErr was expected (by cmd.want), so log it instead of returning it. + s.Logf("[%v]\n", waitErr) } return nil } |
