diff options
| author | Robert Griesemer <gri@golang.org> | 2022-12-05 16:17:56 -0800 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-12-06 18:32:51 +0000 |
| commit | dfd13ce59d74638baff4f94d64851cda53e63bdc (patch) | |
| tree | 1335d8172ad669c22db0570a4884e74f0f88e181 /src/cmd/compile | |
| parent | 98da0fb43fb481a25b3b4399cd9f517fe94d9f3f (diff) | |
| download | go-dfd13ce59d74638baff4f94d64851cda53e63bdc.tar.xz | |
go/types, types2: better error message for invalid method expression
Fixes #53358.
Change-Id: I38528da1596b6e1aaedcab89b1513fb8acac596c
Reviewed-on: https://go-review.googlesource.com/c/go/+/455335
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>
Diffstat (limited to 'src/cmd/compile')
| -rw-r--r-- | src/cmd/compile/internal/types2/call.go | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/types2/call.go b/src/cmd/compile/internal/types2/call.go index ffff11ea6e..50343bf77a 100644 --- a/src/cmd/compile/internal/types2/call.go +++ b/src/cmd/compile/internal/types2/call.go @@ -573,7 +573,11 @@ func (check *Checker) selector(x *operand, e *syntax.SelectorExpr, def *Named) { } if indirect { - check.errorf(e.Sel, InvalidMethodExpr, "cannot call pointer method %s on %s", sel, x.typ) + if x.mode == typexpr { + check.errorf(e.Sel, InvalidMethodExpr, "invalid method expression %s.%s (needs pointer receiver (*%s).%s)", x.typ, sel, x.typ, sel) + } else { + check.errorf(e.Sel, InvalidMethodExpr, "cannot call pointer method %s on %s", sel, x.typ) + } goto Error } |