diff options
| author | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2025-05-22 18:06:27 +0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2025-05-22 09:51:56 -0700 |
| commit | a0dc7bf08481d906cb7d65d86bb347a583d84fd0 (patch) | |
| tree | 8a98f34e0006f8a2769a194d18093511d167c924 /src/cmd/compile | |
| parent | 53b9eae3875122a65b387adf18c5cb7a67e824d7 (diff) | |
| download | go-a0dc7bf08481d906cb7d65d86bb347a583d84fd0.tar.xz | |
cmd/compile: fix ICE when transforming loopvar
When transforming for loop variables, the compiler does roughly
following steps:
(1) prebody = {z := z' for z in leaked}
...
(4) init' = (init : s/z/z' for z in leaked)
However, the definition of z is not updated to `z := z'` statement,
causing ReassignOracle incorrectly use the new init statement with z'
instead of z, trigger the ICE.
Fixing this by updating the correct/new definition statement for z
during the prebody initialization.
Fixes #73823
Change-Id: Ice2a6741be7478506c58f4000f591d5582029136
Reviewed-on: https://go-review.googlesource.com/c/go/+/675475
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: David Chase <drchase@google.com>
Diffstat (limited to 'src/cmd/compile')
| -rw-r--r-- | src/cmd/compile/internal/loopvar/loopvar.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/cmd/compile/internal/loopvar/loopvar.go b/src/cmd/compile/internal/loopvar/loopvar.go index 030fc04c13..5a4590d299 100644 --- a/src/cmd/compile/internal/loopvar/loopvar.go +++ b/src/cmd/compile/internal/loopvar/loopvar.go @@ -305,6 +305,7 @@ func ForCapture(fn *ir.Func) []VarAndLoop { as := ir.NewAssignStmt(x.Pos(), z, tz) as.Def = true as.SetTypecheck(1) + z.Defn = as preBody.Append(as) dclFixups[z] = as |