diff options
| author | Keith Randall <khr@golang.org> | 2023-09-18 13:31:49 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2023-10-06 17:02:53 +0000 |
| commit | cbcf8efa5f749b4e5bceda8682070cd9cf84bee5 (patch) | |
| tree | 0e8f56257343458b5ee320a146f27ed001d9fbf8 /src/cmd/compile/internal/walk/expr.go | |
| parent | b455e239aeeeb1d33eaa34e62c397f3408245a0c (diff) | |
| download | go-cbcf8efa5f749b4e5bceda8682070cd9cf84bee5.tar.xz | |
cmd/compile: use cache in front of type assert runtime call
That way we don't need to call into the runtime for every
type assertion (to an interface type).
name old time/op new time/op delta
TypeAssert-24 3.78ns ± 3% 1.00ns ± 1% -73.53% (p=0.000 n=10+8)
Change-Id: I0ba308aaf0f24a5495b4e13c814d35af0c58bfde
Reviewed-on: https://go-review.googlesource.com/c/go/+/529316
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Diffstat (limited to 'src/cmd/compile/internal/walk/expr.go')
| -rw-r--r-- | src/cmd/compile/internal/walk/expr.go | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/walk/expr.go b/src/cmd/compile/internal/walk/expr.go index a3caa4db36..914011d135 100644 --- a/src/cmd/compile/internal/walk/expr.go +++ b/src/cmd/compile/internal/walk/expr.go @@ -731,10 +731,15 @@ func walkDotType(n *ir.TypeAssertExpr, init *ir.Nodes) ir.Node { lsym := types.LocalPkg.Lookup(fmt.Sprintf(".typeAssert.%d", typeAssertGen)).LinksymABI(obj.ABI0) typeAssertGen++ off := 0 + off = objw.SymPtr(lsym, off, typecheck.LookupRuntimeVar("emptyTypeAssertCache"), 0) off = objw.SymPtr(lsym, off, reflectdata.TypeSym(n.Type()).Linksym(), 0) off = objw.Bool(lsym, off, n.Op() == ir.ODOTTYPE2) // CanFail off += types.PtrSize - 1 - objw.Global(lsym, int32(off), obj.LOCAL|obj.NOPTR) + objw.Global(lsym, int32(off), obj.LOCAL) + // Set the type to be just a single pointer, as the cache pointer is the + // only one that GC needs to see. + lsym.Gotype = reflectdata.TypeLinksym(types.Types[types.TUINT8].PtrTo()) + n.Descriptor = lsym } return n |