diff options
| author | Cherry Mui <cherryyz@google.com> | 2022-03-01 12:02:38 -0500 |
|---|---|---|
| committer | Cherry Mui <cherryyz@google.com> | 2022-03-01 21:27:42 +0000 |
| commit | b0db2f00a0d540c3d3f5d14433da2e3e1ad41f9f (patch) | |
| tree | 6b4e4adac4981ddc85a2713dadf40684d2c3ebb3 /src/cmd/compile/internal/walk/closure.go | |
| parent | f4722d84499cc07fe8c8beb9b3154e59b7d21adf (diff) | |
| download | go-b0db2f00a0d540c3d3f5d14433da2e3e1ad41f9f.tar.xz | |
cmd/compile: use AutogeneratedPos for method value wrapper
We use AutogeneratedPos for most compiler-generated functions. But
for method value wrappers we currently don't. Instead, we use the
Pos for their (direct) declaration if there is one, otherwise
not set it in methodValueWrapper, which will probably cause it to
inherit from the caller, i.e. the Pos of that method value
expression. If that Pos has inline information, it will cause the
method wrapper to have bogus inline information, which could lead
to infinite loop when printing a stack trace.
Change it to use AutogeneratedPos instead.
Fixes #51401.
Change-Id: I398dfe85f9f875e1fd82dc2f489dab63ada6570d
Reviewed-on: https://go-review.googlesource.com/c/go/+/388794
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src/cmd/compile/internal/walk/closure.go')
| -rw-r--r-- | src/cmd/compile/internal/walk/closure.go | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/src/cmd/compile/internal/walk/closure.go b/src/cmd/compile/internal/walk/closure.go index 68e16803be..f7bd2e0e07 100644 --- a/src/cmd/compile/internal/walk/closure.go +++ b/src/cmd/compile/internal/walk/closure.go @@ -235,15 +235,7 @@ func methodValueWrapper(dot *ir.SelectorExpr) *ir.Name { saveLineNo := base.Pos ir.CurFunc = nil - // Set line number equal to the line number where the method is declared. - if pos := dot.Selection.Pos; pos.IsKnown() { - base.Pos = pos - } - // Note: !dot.Selection.Pos.IsKnown() happens for method expressions where - // the method is implicitly declared. The Error method of the - // built-in error type is one such method. We leave the line - // number at the use of the method expression in this - // case. See issue 29389. + base.Pos = base.AutogeneratedPos tfn := ir.NewFuncType(base.Pos, nil, typecheck.NewFuncParams(t0.Params(), true), |