diff options
| author | Jakub Ciolek <jakub@ciolek.dev> | 2023-01-10 08:36:00 +0100 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2023-01-20 05:01:15 +0000 |
| commit | 8354f6b5bb5baf03cb64dbf736c276f297ebea96 (patch) | |
| tree | 31c0363fcb2016de05805715bda1cd91d6ef25c6 /src/cmd/compile/internal/ssa/value.go | |
| parent | 3e77efc7204407c5c8882bec42fdcaa88ef40a9b (diff) | |
| download | go-8354f6b5bb5baf03cb64dbf736c276f297ebea96.tar.xz | |
cmd/compile: use a boolean as a avoid clobbering flags mov marker
The Value type implements Aux interface because it is being used as a
"avoid clobbering flags" marker by amd64, x86 and s390x SSA parts.
Create a boolean that implements the Aux interface. Use it as the marker
instead. We no longer need Value to implement Aux.
Resolves a TODO.
See CL 275756 for more info.
Change-Id: I8a1eddf7e738b8aa31e82f3c4c590bafd2cdc56b
Reviewed-on: https://go-review.googlesource.com/c/go/+/461156
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Run-TryBot: Jakub Ciolek <jakub@ciolek.dev>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Diffstat (limited to 'src/cmd/compile/internal/ssa/value.go')
| -rw-r--r-- | src/cmd/compile/internal/ssa/value.go | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/cmd/compile/internal/ssa/value.go b/src/cmd/compile/internal/ssa/value.go index 643fa36e25..0567b3e214 100644 --- a/src/cmd/compile/internal/ssa/value.go +++ b/src/cmd/compile/internal/ssa/value.go @@ -554,9 +554,6 @@ func (v *Value) removeable() bool { return true } -// TODO(mdempsky): Shouldn't be necessary; see discussion at golang.org/cl/275756 -func (*Value) CanBeAnSSAAux() {} - // AutoVar returns a *Name and int64 representing the auto variable and offset within it // where v should be spilled. func AutoVar(v *Value) (*ir.Name, int64) { |