diff options
| author | Devon H. O'Dell <dhobsd@google.com> | 2024-01-04 11:49:17 -0500 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-01-04 17:31:12 +0000 |
| commit | 15dcdeb5aacb4503e3d053f198bd4669d5cec2aa (patch) | |
| tree | 2d10f68540a4ef6f4d017ae57993adfebc1f14d0 /src/cmd/api/main_test.go | |
| parent | 6db1102605f227093ea95538f0fe9e46022ad7ea (diff) | |
| download | go-15dcdeb5aacb4503e3d053f198bd4669d5cec2aa.tar.xz | |
cmd/api: fix panic on exported basic type aliases
The order of emitting named type and type aliases in the `Walker`'s
`emitType` function is inverted. When the type alias references a basic
type, this causes a panic as the type assertion on `*types.Named` fails.
This change reorders the logic such that type aliases are emitted prior
to this type assertion.
Fixes #64958
Change-Id: I52dbe13999978912ded788d9cf4948103869bcfa
Reviewed-on: https://go-review.googlesource.com/c/go/+/554076
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'src/cmd/api/main_test.go')
| -rw-r--r-- | src/cmd/api/main_test.go | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/cmd/api/main_test.go b/src/cmd/api/main_test.go index 94e159e7d8..7985055b5c 100644 --- a/src/cmd/api/main_test.go +++ b/src/cmd/api/main_test.go @@ -957,17 +957,17 @@ func (w *Walker) emitType(obj *types.TypeName) { if w.isDeprecated(obj) { w.emitf("type %s //deprecated", name) } + typ := obj.Type() + if obj.IsAlias() { + w.emitf("type %s = %s", name, w.typeString(typ)) + return + } if tparams := obj.Type().(*types.Named).TypeParams(); tparams != nil { var buf bytes.Buffer buf.WriteString(name) w.writeTypeParams(&buf, tparams, true) name = buf.String() } - typ := obj.Type() - if obj.IsAlias() { - w.emitf("type %s = %s", name, w.typeString(typ)) - return - } switch typ := typ.Underlying().(type) { case *types.Struct: w.emitStructType(name, typ) |