diff options
| author | Bryan C. Mills <bcmills@google.com> | 2022-12-08 08:44:51 -0500 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-01-19 20:45:58 +0000 |
| commit | fbf14ae166ceeb94c14b3d752c7353f5472b4e29 (patch) | |
| tree | 6582543e05b9a23b50fa14388855b01110c00f05 | |
| parent | caf8fb1e828deb05cdd2df45f9de13c048de39c6 (diff) | |
| download | go-fbf14ae166ceeb94c14b3d752c7353f5472b4e29.tar.xz | |
runtime: remove arbitrary GOARCH constraints in finalizer tests
These tests were only run on GOARCH=amd64, but the rationale given in
CL 11858043 was GC precision on 32-bit platforms. Today, we have far
more 64-bit platforms than just amd64, and I believe that GC precision
on 32-bit platforms has been substantially improved as well.
The GOARCH restriction seems unnecessary.
Updates #57166.
Updates #5368.
Change-Id: I45c608b6fa721012792c96d4ed94a6d772b90210
Reviewed-on: https://go-review.googlesource.com/c/go/+/456120
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Austin Clements <austin@google.com>
| -rw-r--r-- | src/runtime/mfinal_test.go | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/src/runtime/mfinal_test.go b/src/runtime/mfinal_test.go index 61d625ac27..87d31c472c 100644 --- a/src/runtime/mfinal_test.go +++ b/src/runtime/mfinal_test.go @@ -21,10 +21,6 @@ type Tinter interface { } func TestFinalizerType(t *testing.T) { - if runtime.GOARCH != "amd64" { - t.Skipf("Skipping on non-amd64 machine") - } - ch := make(chan bool, 10) finalize := func(x *int) { if *x != 97531 { @@ -82,9 +78,6 @@ type bigValue struct { } func TestFinalizerInterfaceBig(t *testing.T) { - if runtime.GOARCH != "amd64" { - t.Skipf("Skipping on non-amd64 machine") - } ch := make(chan bool) done := make(chan bool, 1) go func() { |