diff options
| author | Max Altgelt <max.altgelt@nextron-systems.com> | 2023-02-10 11:38:42 +0100 |
|---|---|---|
| committer | Quim Muntal <quimmuntal@gmail.com> | 2023-02-11 09:26:59 +0000 |
| commit | e03ee85ef434f307500a71927dfb3e876161847a (patch) | |
| tree | ee4d3701a74ced8b3e11e9b8e72a6826f8c3ef71 | |
| parent | bd5de19b368536574682c45cca9f7864a4eca6d2 (diff) | |
| download | go-e03ee85ef434f307500a71927dfb3e876161847a.tar.xz | |
runtime: Allow handling of EXCEPTION_IN_PAGE_ERROR
Currently, access faults on memory mapped files on Windows (e.g.
from the drive the memory mapped file is on being ejected) cause
a runtime fault that can not be caught by debug.SetPanicOnFault.
On Unix systems, on the other hand, this causes a SIGBUS signal,
which can be caught by debug.SetPanicOnFault. Given that the
documentation of debug.SetPanicOnFault mentions handling memory
mapped files, this is arguably the correct behaviour.
Add handling, analogous to SIGBUS, to EXCEPTION_IN_PAGE_ERROR
on Windows, to allow for users to handle this error.
Fixes #58457
Change-Id: Ic7695fc01271f3552782089ac75c403d5279811f
Reviewed-on: https://go-review.googlesource.com/c/go/+/467195
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
| -rw-r--r-- | src/runtime/defs_windows.go | 1 | ||||
| -rw-r--r-- | src/runtime/signal_windows.go | 3 |
2 files changed, 3 insertions, 1 deletions
diff --git a/src/runtime/defs_windows.go b/src/runtime/defs_windows.go index 7e5d9570f8..60f20a5c2c 100644 --- a/src/runtime/defs_windows.go +++ b/src/runtime/defs_windows.go @@ -27,6 +27,7 @@ const ( _CTRL_SHUTDOWN_EVENT = 0x6 _EXCEPTION_ACCESS_VIOLATION = 0xc0000005 + _EXCEPTION_IN_PAGE_ERROR = 0xc0000006 _EXCEPTION_BREAKPOINT = 0x80000003 _EXCEPTION_ILLEGAL_INSTRUCTION = 0xc000001d _EXCEPTION_FLT_DENORMAL_OPERAND = 0xc000008d diff --git a/src/runtime/signal_windows.go b/src/runtime/signal_windows.go index 1ea0d1e06c..e4258f01b0 100644 --- a/src/runtime/signal_windows.go +++ b/src/runtime/signal_windows.go @@ -76,6 +76,7 @@ func isgoexception(info *exceptionrecord, r *context) bool { default: return false case _EXCEPTION_ACCESS_VIOLATION: + case _EXCEPTION_IN_PAGE_ERROR: case _EXCEPTION_INT_DIVIDE_BY_ZERO: case _EXCEPTION_INT_OVERFLOW: case _EXCEPTION_FLT_DENORMAL_OPERAND: @@ -345,7 +346,7 @@ func sigpanic() { } switch gp.sig { - case _EXCEPTION_ACCESS_VIOLATION: + case _EXCEPTION_ACCESS_VIOLATION, _EXCEPTION_IN_PAGE_ERROR: if gp.sigcode1 < 0x1000 { panicmem() } |