diff options
| author | Than McIntosh <thanm@google.com> | 2023-02-09 11:31:57 -0500 |
|---|---|---|
| committer | Than McIntosh <thanm@google.com> | 2023-02-10 14:29:46 +0000 |
| commit | 48f4728211c1c4299728b6b3a04a6ddf997d9ec6 (patch) | |
| tree | 4173aafd48ab3637537fb71a0f59af150c77b32a | |
| parent | 7d57a9ce82cc6841307bc1c3383808b36a884bc9 (diff) | |
| download | go-48f4728211c1c4299728b6b3a04a6ddf997d9ec6.tar.xz | |
cmd/cgo: add -fno-stack-protector to CFLAGS (again)
Add -fno-stack-protector back to the default set of CFLAGS for cgo, so
as to avoid problems with internal linking locating the library
containing the "__stack_chk_fail_local" support function that some
compilers emit (the specific archive can vary based on GOOS).
Updates #52919.
Updates #54313.
Updates #57261.
Updates #58385.
Change-Id: I4591bfb15501f04b7afe1fcd50c4fb93c86db63d
Reviewed-on: https://go-review.googlesource.com/c/go/+/466935
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
| -rw-r--r-- | src/runtime/cgo/cgo.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/runtime/cgo/cgo.go b/src/runtime/cgo/cgo.go index 6d721bc8ff..1e3a502918 100644 --- a/src/runtime/cgo/cgo.go +++ b/src/runtime/cgo/cgo.go @@ -23,7 +23,9 @@ package cgo #cgo solaris LDFLAGS: -lxnet #cgo solaris LDFLAGS: -lsocket -#cgo CFLAGS: -Wall -Werror +// Use -fno-stack-protector to avoid problems locating the +// proper support functions. See issues #52919, #54313, #58385. +#cgo CFLAGS: -Wall -Werror -fno-stack-protector #cgo solaris CPPFLAGS: -D_POSIX_PTHREAD_SEMANTICS |