diff options
| author | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2026-03-03 23:10:05 +0700 |
|---|---|---|
| committer | Carlos Amedee <carlos@golang.org> | 2026-03-19 13:58:44 -0700 |
| commit | 19c660de6bc9e520dd5e3fece09752b396deb386 (patch) | |
| tree | 63cdb00fa89576e61e4e822878e725dccf67f867 | |
| parent | b02c84a684e19df70bcac25794e19f3f63bec939 (diff) | |
| download | go-19c660de6bc9e520dd5e3fece09752b396deb386.tar.xz | |
[release-branch.go1.25] cmd/compile/internal/typecheck: simplify tcSliceHeader
types2 handles all constant-related bounds checks in user Go code now,
so it's safe to remove all constants checking in tcSliceHeader function.
Fixed #77921
Change-Id: Ibc137c84792d4898eb073cdeabac175684f73746
Reviewed-on: https://go-review.googlesource.com/c/go/+/751040
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/753600
Reviewed-by: Mark Freeman <markfreeman@google.com>
| -rw-r--r-- | src/cmd/compile/internal/typecheck/expr.go | 13 | ||||
| -rw-r--r-- | test/fixedbugs/issue77919.go | 15 |
2 files changed, 15 insertions, 13 deletions
diff --git a/src/cmd/compile/internal/typecheck/expr.go b/src/cmd/compile/internal/typecheck/expr.go index 44a69f0332..7dc29636cc 100644 --- a/src/cmd/compile/internal/typecheck/expr.go +++ b/src/cmd/compile/internal/typecheck/expr.go @@ -7,7 +7,6 @@ package typecheck import ( "fmt" "go/constant" - "go/token" "internal/types/errors" "strings" @@ -826,18 +825,6 @@ func tcSliceHeader(n *ir.SliceHeaderExpr) ir.Node { n.Len = DefaultLit(Expr(n.Len), types.Types[types.TINT]) n.Cap = DefaultLit(Expr(n.Cap), types.Types[types.TINT]) - if ir.IsConst(n.Len, constant.Int) && ir.Int64Val(n.Len) < 0 { - base.Fatalf("len for OSLICEHEADER must be non-negative") - } - - if ir.IsConst(n.Cap, constant.Int) && ir.Int64Val(n.Cap) < 0 { - base.Fatalf("cap for OSLICEHEADER must be non-negative") - } - - if ir.IsConst(n.Len, constant.Int) && ir.IsConst(n.Cap, constant.Int) && constant.Compare(n.Len.Val(), token.GTR, n.Cap.Val()) { - base.Fatalf("len larger than cap for OSLICEHEADER") - } - return n } diff --git a/test/fixedbugs/issue77919.go b/test/fixedbugs/issue77919.go new file mode 100644 index 0000000000..834331e49e --- /dev/null +++ b/test/fixedbugs/issue77919.go @@ -0,0 +1,15 @@ +// compile + +// Copyright 2026 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package main + +var sink any + +func main() { + i := 0 + output := make([]string, 8, i) + sink = output +} |