diff options
| author | Ian Lance Taylor <iant@golang.org> | 2025-09-01 09:18:08 -0700 |
|---|---|---|
| committer | Carlos Amedee <carlos@golang.org> | 2025-10-01 11:58:18 -0700 |
| commit | 0b53e410f8f5cd1341ea492914d9b7fd17f3f6c1 (patch) | |
| tree | d84d9bd606d75810943cacc092a31e1489635e38 | |
| parent | 7735dc90ed6f157a7a9681dd77a0b05f0f098e78 (diff) | |
| download | go-0b53e410f8f5cd1341ea492914d9b7fd17f3f6c1.tar.xz | |
[release-branch.go1.25] debug/pe: permit symbols with no name
They are reportedly generated by llvm-mingw clang21.
For #75219
Fixes #75221
Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff
Reviewed-on: https://go-review.googlesource.com/c/go/+/700137
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit ea00650784bc2909580c7decf729f668349aa939)
Reviewed-on: https://go-review.googlesource.com/c/go/+/708356
| -rw-r--r-- | src/debug/pe/symbol.go | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/debug/pe/symbol.go b/src/debug/pe/symbol.go index 6e8d9d16c2..80acebe9f1 100644 --- a/src/debug/pe/symbol.go +++ b/src/debug/pe/symbol.go @@ -98,7 +98,12 @@ func readCOFFSymbols(fh *FileHeader, r io.ReadSeeker) ([]COFFSymbol, error) { // isSymNameOffset checks symbol name if it is encoded as offset into string table. func isSymNameOffset(name [8]byte) (bool, uint32) { if name[0] == 0 && name[1] == 0 && name[2] == 0 && name[3] == 0 { - return true, binary.LittleEndian.Uint32(name[4:]) + offset := binary.LittleEndian.Uint32(name[4:]) + if offset == 0 { + // symbol has no name + return false, 0 + } + return true, offset } return false, 0 } |