aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDiogo Pinela <diogoid7400@gmail.com>2019-03-28 20:35:28 +0000
committerJonathan Amsterdam <jba@google.com>2024-07-11 00:10:03 +0000
commitdfaaa91f0537f806a02ff2dd71b79844cd16cc4e (patch)
tree409392a3f76d743c15251d4b1d04f3327b165296
parent5881d857c573874bde9417e97df3267f19c7ecb6 (diff)
downloadgo-dfaaa91f0537f806a02ff2dd71b79844cd16cc4e.tar.xz
os: clarify that IsNotExist, IsExist, IsPermission and IsTimeout work with nil errors
Referring to these functions' parameter as "*the* error" could be taken to imply that a non-nil error from elsewhere is expected; referring to it as "its argument" avoids that ambiguity. Fixes #31065 Change-Id: I117892dd53fff6f92d11a416e4abedee5d2f9337 Reviewed-on: https://go-review.googlesource.com/c/go/+/170077 Reviewed-by: Rob Pike <r@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
-rw-r--r--src/os/error.go8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/os/error.go b/src/os/error.go
index 5a824a9e0e..284b9e992c 100644
--- a/src/os/error.go
+++ b/src/os/error.go
@@ -71,7 +71,7 @@ func NewSyscallError(syscall string, err error) error {
return &SyscallError{syscall, err}
}
-// IsExist returns a boolean indicating whether the error is known to report
+// IsExist returns a boolean indicating whether its argument is known to report
// that a file or directory already exists. It is satisfied by [ErrExist] as
// well as some syscall errors.
//
@@ -81,7 +81,7 @@ func IsExist(err error) bool {
return underlyingErrorIs(err, ErrExist)
}
-// IsNotExist returns a boolean indicating whether the error is known to
+// IsNotExist returns a boolean indicating whether its argument is known to
// report that a file or directory does not exist. It is satisfied by
// [ErrNotExist] as well as some syscall errors.
//
@@ -91,7 +91,7 @@ func IsNotExist(err error) bool {
return underlyingErrorIs(err, ErrNotExist)
}
-// IsPermission returns a boolean indicating whether the error is known to
+// IsPermission returns a boolean indicating whether its argument is known to
// report that permission is denied. It is satisfied by [ErrPermission] as well
// as some syscall errors.
//
@@ -101,7 +101,7 @@ func IsPermission(err error) bool {
return underlyingErrorIs(err, ErrPermission)
}
-// IsTimeout returns a boolean indicating whether the error is known
+// IsTimeout returns a boolean indicating whether its argument is known
// to report that a timeout occurred.
//
// This function predates [errors.Is], and the notion of whether an