diff options
| author | Russ Cox <rsc@golang.org> | 2022-04-12 16:19:37 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2022-04-12 21:26:36 +0000 |
| commit | f2105c4cf825fe09ece01c9d554f6c0a5bc06a03 (patch) | |
| tree | dccffc39e277ed70e910809d87037106111a7c88 | |
| parent | b1bd8c59b0eedfe9d0e2674f9a2e942666b5f478 (diff) | |
| download | go-x-review-f2105c4cf825fe09ece01c9d554f6c0a5bc06a03.tar.xz | |
git-codereview: remove -trust
We don't use that label anymore.
Change-Id: Ic31841efaea5d9d9ae38077d8c3a3b6c548fee88
Reviewed-on: https://go-review.googlesource.com/c/review/+/399117
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
| -rw-r--r-- | git-codereview/doc.go | 7 | ||||
| -rw-r--r-- | git-codereview/mail.go | 7 |
2 files changed, 3 insertions, 11 deletions
diff --git a/git-codereview/doc.go b/git-codereview/doc.go index 75082d4..0f091ee 100644 --- a/git-codereview/doc.go +++ b/git-codereview/doc.go @@ -218,8 +218,8 @@ It is run by the shell scripts installed by the “git codereview hooks” comma The mail command starts the code review process for the pending change. git codereview mail [-r email,...] [-cc email,...] - [-diff] [-f] [-nokeycheck] [-hashtag tag,...] [-nokeycheck] - [-topic topic] [-trust] [-trybot] [-wip] + [-diff] [-f] [-hashtag tag,...] [-nokeycheck] + [-topic topic] [-trybot] [-wip] [revision] It pushes the pending change commit in the current branch to the Gerrit code @@ -254,9 +254,6 @@ The -nokeycheck flag disables the Gerrit server check for committed files containing data that looks like public keys. (The most common time -nokeycheck is needed is when checking in test cases for cryptography libraries.) -The -trust flag sets a Trust+1 vote on any uploaded changes. -The Go project uses this vote to identify trusted commit authors. - The -trybot flag sets a Run-TryBot+1 vote on any uploaded changes. The Go project uses this vote to start running integration tests on the CL. diff --git a/git-codereview/mail.go b/git-codereview/mail.go index 44d83d6..f8e6485 100644 --- a/git-codereview/mail.go +++ b/git-codereview/mail.go @@ -24,7 +24,6 @@ func cmdMail(args []string) { hashtagList = new(stringList) // installed below noKeyCheck = flags.Bool("nokeycheck", false, "set 'git push -o nokeycheck', to prevent Gerrit from checking for private keys") topic = flags.String("topic", "", "set Gerrit topic") - trust = flags.Bool("trust", false, "add a Trust+1 vote to the CL") trybot = flags.Bool("trybot", false, "run trybots on the uploaded CLs") wip = flags.Bool("wip", false, "set the status of a change to Work-in-Progress") noverify = flags.Bool("no-verify", false, "disable presubmits") @@ -37,7 +36,7 @@ func cmdMail(args []string) { fmt.Fprintf(stderr(), "Usage: %s mail %s [-r reviewer,...] [-cc mail,...]\n"+ "\t[-f] [-diff] [-hashtag tag,...] [-nokeycheck] [-topic topic]\n"+ - "\t[-trust] [-trybot] [-wip] [commit]\n", progName, globalFlags) + "\t[-trybot] [-wip] [commit]\n", progName, globalFlags) exit(2) } flags.Parse(args) @@ -140,10 +139,6 @@ func cmdMail(args []string) { refSpec += start + "topic=" + *topic start = "," } - if *trust { - refSpec += start + "l=Trust" - start = "," - } if *trybot { refSpec += start + "l=Run-TryBot" start = "," |