From 3d7db7df374a3c9a2e5b1ecad9e4e02d6588dc91 Mon Sep 17 00:00:00 2001 From: Nicola Murino Date: Sun, 22 Sep 2024 09:31:49 +0000 Subject: design/68723-crypto-ssh-v2.md: change NewPublicKey signature It now accepts a crypto.PublicKey instead of an empty interface. All public keys in the standard library implement this interface. Change-Id: I873175a4d4e57803dc3cafdadb800b4f34ae0ca1 GitHub-Last-Rev: 05a3b07a3ad37e5d46be7d24d8f2245b4cfdc1ba GitHub-Pull-Request: golang/proposal#54 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/614279 Reviewed-by: Nicola Murino Commit-Queue: Nicola Murino Auto-Submit: Nicola Murino --- design/68723-crypto-ssh-v2.md | 4 ++++ design/68723/ssh.html | 10 +++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/design/68723-crypto-ssh-v2.md b/design/68723-crypto-ssh-v2.md index 5210f9e..94f21f7 100644 --- a/design/68723-crypto-ssh-v2.md +++ b/design/68723-crypto-ssh-v2.md @@ -425,6 +425,10 @@ func MarshalPrivateKey(key crypto.PrivateKey, options MarshalPrivateKeyOptions) This way we can remove `MarshalPrivateKeyWithPassphrase` because the passphrase is now an option. We can easily add support for other options, for example making salt rounds confgurable, see [golang/go#68700](https://github.com/golang/go/issues/68700). +### NewPublicKey + +Change the `NewPublicKey` signature to accept `crypto.PublicKey` instead of an empty interface. All public keys in the standard library implement this interface. + ### Deprecated API and algorithms removal We'll remove DSA support, see [here](https://lists.mindrot.org/pipermail/openssh-unix-announce/2024-January/000156.html) for DSA status in OpenSSH, it is already disabled by default and will be removed in January, 2025. diff --git a/design/68723/ssh.html b/design/68723/ssh.html index 47c353a..81bf882 100644 --- a/design/68723/ssh.html +++ b/design/68723/ssh.html @@ -777,7 +777,7 @@ so its API may be changed when pressing needs arise.
  • type PublicKey