From 34a9c69fcd8d9ae8d404ff3d39bd81b749a78ca1 Mon Sep 17 00:00:00 2001 From: Michael Anthony Knyszek Date: Thu, 18 Feb 2021 21:55:26 +0000 Subject: design: regenerate graphs for GC pacer redesign A couple of the graphs were wrong (from the wrong scenario, that is) because I copied them in manually. Fatal mistake. Regenerate the graphs following the usual pipeline. Because there's a degree of jitter and randomness in these graphs they end up slightly different, but they're all mostly the same. By regenerating these graphs, it also adds a new line to each graph for the live heap size. I think this is nice for readability, so I'll let that get updated too. For golang/go#44167. Change-Id: I097f812ba07ca7fd740d8460e2830de6492b3945 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/293790 Reviewed-by: Michael Pratt --- design/44167/pacer-plots/new-big-globals.png | Bin 43906 -> 44867 bytes design/44167/pacer-plots/new-big-stacks.png | Bin 42983 -> 44465 bytes design/44167/pacer-plots/new-heavy-jitter-alloc.png | Bin 56271 -> 50618 bytes design/44167/pacer-plots/new-heavy-step-alloc.png | Bin 43388 -> 43035 bytes design/44167/pacer-plots/new-high-GOGC.png | Bin 42416 -> 41332 bytes design/44167/pacer-plots/new-jitter-alloc.png | Bin 51741 -> 52156 bytes design/44167/pacer-plots/new-osc-alloc.png | Bin 54105 -> 55432 bytes design/44167/pacer-plots/new-steady.png | Bin 40527 -> 41890 bytes design/44167/pacer-plots/new-step-alloc.png | Bin 43239 -> 43361 bytes design/44167/pacer-plots/old-big-globals.png | Bin 40511 -> 42038 bytes design/44167/pacer-plots/old-big-stacks.png | Bin 42579 -> 42458 bytes design/44167/pacer-plots/old-heavy-jitter-alloc.png | Bin 47119 -> 47662 bytes design/44167/pacer-plots/old-heavy-step-alloc.png | Bin 40299 -> 41744 bytes design/44167/pacer-plots/old-high-GOGC.png | Bin 42768 -> 41829 bytes design/44167/pacer-plots/old-jitter-alloc.png | Bin 50822 -> 49883 bytes design/44167/pacer-plots/old-osc-alloc.png | Bin 50427 -> 49573 bytes design/44167/pacer-plots/old-steady.png | Bin 40116 -> 41516 bytes design/44167/pacer-plots/old-step-alloc.png | Bin 39908 -> 40862 bytes 18 files changed, 0 insertions(+), 0 deletions(-) diff --git a/design/44167/pacer-plots/new-big-globals.png b/design/44167/pacer-plots/new-big-globals.png index 958f985..7733756 100644 Binary files a/design/44167/pacer-plots/new-big-globals.png and b/design/44167/pacer-plots/new-big-globals.png differ diff --git a/design/44167/pacer-plots/new-big-stacks.png b/design/44167/pacer-plots/new-big-stacks.png index 1ab5583..e5c771f 100644 Binary files a/design/44167/pacer-plots/new-big-stacks.png and b/design/44167/pacer-plots/new-big-stacks.png differ diff --git a/design/44167/pacer-plots/new-heavy-jitter-alloc.png b/design/44167/pacer-plots/new-heavy-jitter-alloc.png index e5596ec..12aa9ef 100644 Binary files a/design/44167/pacer-plots/new-heavy-jitter-alloc.png and b/design/44167/pacer-plots/new-heavy-jitter-alloc.png differ diff --git a/design/44167/pacer-plots/new-heavy-step-alloc.png b/design/44167/pacer-plots/new-heavy-step-alloc.png index d1261ef..3bb6f01 100644 Binary files a/design/44167/pacer-plots/new-heavy-step-alloc.png and b/design/44167/pacer-plots/new-heavy-step-alloc.png differ diff --git a/design/44167/pacer-plots/new-high-GOGC.png b/design/44167/pacer-plots/new-high-GOGC.png index 8c9291f..f71df01 100644 Binary files a/design/44167/pacer-plots/new-high-GOGC.png and b/design/44167/pacer-plots/new-high-GOGC.png differ diff --git a/design/44167/pacer-plots/new-jitter-alloc.png b/design/44167/pacer-plots/new-jitter-alloc.png index b021d60..8aa5337 100644 Binary files a/design/44167/pacer-plots/new-jitter-alloc.png and b/design/44167/pacer-plots/new-jitter-alloc.png differ diff --git a/design/44167/pacer-plots/new-osc-alloc.png b/design/44167/pacer-plots/new-osc-alloc.png index 2d18192..8dada21 100644 Binary files a/design/44167/pacer-plots/new-osc-alloc.png and b/design/44167/pacer-plots/new-osc-alloc.png differ diff --git a/design/44167/pacer-plots/new-steady.png b/design/44167/pacer-plots/new-steady.png index 4d4f45c..943acfe 100644 Binary files a/design/44167/pacer-plots/new-steady.png and b/design/44167/pacer-plots/new-steady.png differ diff --git a/design/44167/pacer-plots/new-step-alloc.png b/design/44167/pacer-plots/new-step-alloc.png index a8639f3..dd78b60 100644 Binary files a/design/44167/pacer-plots/new-step-alloc.png and b/design/44167/pacer-plots/new-step-alloc.png differ diff --git a/design/44167/pacer-plots/old-big-globals.png b/design/44167/pacer-plots/old-big-globals.png index d1e1d13..9377718 100644 Binary files a/design/44167/pacer-plots/old-big-globals.png and b/design/44167/pacer-plots/old-big-globals.png differ diff --git a/design/44167/pacer-plots/old-big-stacks.png b/design/44167/pacer-plots/old-big-stacks.png index 80febdf..d1d6802 100644 Binary files a/design/44167/pacer-plots/old-big-stacks.png and b/design/44167/pacer-plots/old-big-stacks.png differ diff --git a/design/44167/pacer-plots/old-heavy-jitter-alloc.png b/design/44167/pacer-plots/old-heavy-jitter-alloc.png index 3d5eb1d..e5319c3 100644 Binary files a/design/44167/pacer-plots/old-heavy-jitter-alloc.png and b/design/44167/pacer-plots/old-heavy-jitter-alloc.png differ diff --git a/design/44167/pacer-plots/old-heavy-step-alloc.png b/design/44167/pacer-plots/old-heavy-step-alloc.png index 8b297cf..c7ade44 100644 Binary files a/design/44167/pacer-plots/old-heavy-step-alloc.png and b/design/44167/pacer-plots/old-heavy-step-alloc.png differ diff --git a/design/44167/pacer-plots/old-high-GOGC.png b/design/44167/pacer-plots/old-high-GOGC.png index 3dbbc20..9cb37de 100644 Binary files a/design/44167/pacer-plots/old-high-GOGC.png and b/design/44167/pacer-plots/old-high-GOGC.png differ diff --git a/design/44167/pacer-plots/old-jitter-alloc.png b/design/44167/pacer-plots/old-jitter-alloc.png index ad8d42c..5d7065b 100644 Binary files a/design/44167/pacer-plots/old-jitter-alloc.png and b/design/44167/pacer-plots/old-jitter-alloc.png differ diff --git a/design/44167/pacer-plots/old-osc-alloc.png b/design/44167/pacer-plots/old-osc-alloc.png index 7527144..e4dcaea 100644 Binary files a/design/44167/pacer-plots/old-osc-alloc.png and b/design/44167/pacer-plots/old-osc-alloc.png differ diff --git a/design/44167/pacer-plots/old-steady.png b/design/44167/pacer-plots/old-steady.png index 7576b9f..c923ef7 100644 Binary files a/design/44167/pacer-plots/old-steady.png and b/design/44167/pacer-plots/old-steady.png differ diff --git a/design/44167/pacer-plots/old-step-alloc.png b/design/44167/pacer-plots/old-step-alloc.png index 2b06691..bef8813 100644 Binary files a/design/44167/pacer-plots/old-step-alloc.png and b/design/44167/pacer-plots/old-step-alloc.png differ -- cgit v1.3