aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-12-18design: add go:wasmexport proposalFrancesco Guardiani
Detailed proposal about issue https://golang.org/issue/42372 For golang/go#42372 Change-Id: I48f5d1d6b055349743e7018f8bc3ebe2fa2bcda1 GitHub-Last-Rev: d10c2d44921519cd0b1c2bffeaf184815b4720f8 GitHub-Pull-Request: golang/proposal#31 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/278692 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-11-25design: type parameter: add rule for composite types in type listsIan Lance Taylor
Also clarify rules for type assertions to generic types and generic types as cases in a type switch. Change-Id: I27bc3c843ba5a57acb7c583c854ff8acd2c043d3 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/272706 Trust: Ian Lance Taylor <iant@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>
2020-09-30design: add GC shape hybrid design doc for the generics implementationKeith Randall
Change-Id: I04ca517644779d011fb28e57ec54c4b7de91fe2c Reviewed-on: https://go-review.googlesource.com/c/proposal/+/258539 Trust: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
2020-09-21design: type parameters: use square brackets in NewPair declarationIan Lance Taylor
Change-Id: If892a757cd45ca3baa9b1008e9b7d950dad9f809 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/256303 Trust: Ian Lance Taylor <iant@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>
2020-09-17design: add generics implementation design docsKeith Randall
Change-Id: I33c636fce2e96677a9c81b15fa574ac136c22402 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/255797 Reviewed-by: Keith Randall <khr@golang.org>
2020-09-10fix typo: method receiver should contain type arguments, not parametersArtem Khvastunov
From what I understand, type parameters can only be used in a type or a function declaration. Thus, in a method receiver, one can only find type arguments. Having `*Iterator[K, V any]` there looks like a little typo to me. The go2go Playground seems to agree with me: [before](https://go2goplay.golang.org/p/dekNQ6Xy8XM) there's a parse error while there's no [after](https://go2goplay.golang.org/p/4B8iTq2AeET). Change-Id: I53e36fca75d3573f56bdb89fbc48bf4284502ffd GitHub-Last-Rev: 4f80c8e8b0c06a9c5457c1cdbe6c2cbfbb515a84 GitHub-Pull-Request: golang/proposal#27 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/253819 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-09-09design: type parameters: pointer methods, clarificationsIan Lance Taylor
Change-Id: Id99fed0f8a980003139581fd5830a89b9a85f401 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/253817 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-09-09design: update issue link for gopls-workspacesHyang-Ah Hana Kim
Now the discussion is moved to the original feature request issue. Change-Id: Ibbe8c06ee6ab25f005e229fb690996c68c98815f GitHub-Last-Rev: ff469c86da08535bd4cfdc11587e1dd3e68752a3 GitHub-Pull-Request: golang/proposal#26 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/253697 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-09-01design: type parameters: don't request Go formattingIan Lance Taylor
It's inconsistent. Change-Id: I33836847ec994d41ec367264df9231495268ea83 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/252157 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-08-29design: type parameters: promote embedded methods from constraintIan Lance Taylor
Change-Id: If4be0f74932c1ec504833549fb01a047dcf8335f Reviewed-on: https://go-review.googlesource.com/c/proposal/+/251444 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-08-28design: type parameters: type parameter lists require namesIan Lance Taylor
Change-Id: Ib3cb641176ccd1c8dfb30558f7e0b7a228193de5 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/251560 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-08-27design: type parameters: various cleanupsIan Lance Taylor
Also drop the idea that we implicitly pass a type parameter to a parameterized type constraint. We can use an interface type literal to get a similar effect. Change-Id: Iebabb9669d5fcd88a79e0c5388f74c4c1d9c0325 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/251137 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-08-26design: type parameters: various minor cleanupsIan Lance Taylor
Change-Id: I54e8a55d392d16650a575826b55417a341830c51 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/250519 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-08-25design: type parameters: type lists don't imply methodsIan Lance Taylor
Change-Id: If45d9b9b75ca2cda1feb4a9ba645648b2e35763e Reviewed-on: https://go-review.googlesource.com/c/proposal/+/250377 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-08-25design: type parameter: tweak type list matching ruleIan Lance Taylor
Change-Id: Ie9cffcd7a3133981a40947c0a3127d4bb83bb4bd Reviewed-on: https://go-review.googlesource.com/c/proposal/+/250317 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-08-24design: type parameters: use square bracketsIan Lance Taylor
Also drop the "type" keyword as the start of type parameter lists, and instead require that constraints always be specified. Also introduced the predeclared name "any". Change-Id: If6b005b101cbbaaac73dc2d1c6e40bffaade3a96 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/249840 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-08-14design: update gopls workspace design with implementation detailsRebecca Stambler
Adding a few more concrete details after discussion today with Heschi. Change-Id: I0216eaa584d8a9048c5138926b2bfad8926cc034 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/248405 Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-08-14design/40724-register-calling: add design docAustin Clements
Change-Id: Ib491db5e2523acf6f21b94924339a22d236717bc Reviewed-on: https://go-review.googlesource.com/c/proposal/+/248178 Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: Martin Möhrmann <moehrmann@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Michael Pratt <mpratt@google.com>
2020-08-13design: type parameters: add constraint type inferenceIan Lance Taylor
Change-Id: Ifefbaf79cd5ca7bcde4a5fc00f26aad5813ffc40 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/247518 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-07-31design/draft-fuzzing.md: update f.Fuzz to include testing.TKatie Hockman
This change also adds a `-fuzztime` flag for `go test`, and an open issue for custom generators. Change-Id: Ifef7e56e10cb5b3e1ff71e952c47f18fc0747114 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/245117 Reviewed-by: Katie Hockman <katie@golang.org>
2020-07-22design/draft-fuzzing.md: clarify feedback requestKatie Hockman
Change-Id: I1c1c701b9606fba0cae4b94baefddb144a6f6cd6 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/244377 Reviewed-by: Katie Hockman <katie@golang.org>
2020-07-22design/40307-fuzzing.md: incorporate feedbackKatie Hockman
Change-Id: Ib4cbdb26a3291ac26def3bdd8d41066d7940a1ec Reviewed-on: https://go-review.googlesource.com/c/proposal/+/244337 Reviewed-by: Katie Hockman <katie@golang.org>
2020-07-22design/40307-fuzzing.md: update example functionsDustin H
Hope this syntax looks good :) Thanks for this cool proposal! Change-Id: I3fa04ca8f8b88b62f8a4a5b556a611f825c6ac3c GitHub-Last-Rev: b2ca18c59b65a0a9719c953a63e710deda8f4d4e GitHub-Pull-Request: golang/proposal#25 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/244058 Reviewed-by: Katie Hockman <katie@golang.org>
2020-07-21design/40307-fuzzing.md: remove TODOKatie Hockman
Change-Id: Ic288026cdfdc689bc4b6d517ef6f88678229f6a9 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/244039 Reviewed-by: Katie Hockman <katie@golang.org>
2020-07-21design/40307-fuzzing.md: add design draftKatie Hockman
Change-Id: Idfd921426537e7fe2368b522f8df9d0cec1bae25 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/243947 Reviewed-by: Filippo Valsorda <filippo@golang.org>
2020-07-21design: fix typos in draft-embedAinar Garipov
Change-Id: I6d999a733bbb7308c66cec751cafb7969bf5814c Reviewed-on: https://go-review.googlesource.com/c/proposal/+/243957 Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Russ Cox <rsc@golang.org>
2020-07-21design: add draft-embed and draft-iofsRuss Cox
See https://golang.org/s/draft-embed-video and https://golang.org/s/draft-iofs-video Change-Id: I61e09d44f10440a64804e6e90ffbcd7fa4bb5d56 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/243946 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
2020-07-02design/draft-gobuild: flag //go:build-only files in Go 1.N go vetRuss Cox
Suggested by thepudds. Thanks! Change-Id: I4b45a04f04989ca28937deaddfea50a3e5514e4b Reviewed-on: https://go-review.googlesource.com/c/proposal/+/240837 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
2020-06-30design/draft-gobuild: remove duplicated aquachain exampleRuss Cox
Change-Id: I05dad87ced2968a34ac7dd08a574e873d4c7e30a Reviewed-on: https://go-review.googlesource.com/c/proposal/+/240617 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
2020-06-30design/draft-gobuild: fix short URLsRuss Cox
Change-Id: I2de8f3344979e5003faa682434737238dfad0679 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/240612 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
2020-06-30design: add draft-gobuild.mdRuss Cox
Draft design for //go:build constraints (replacing // +build). Change-Id: I0f25b370509c94f9b5a5f305f0b0f10b4a595249 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/240549 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
2020-06-30design/go2draft-type-parameters: correct method name in code commentIan Lance Taylor
Change-Id: I5da909db243daea6e8e1ec0898c42b73d426764b Reviewed-on: https://go-review.googlesource.com/c/proposal/+/240577 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-06-28doc/go2draft-type-parameters: fix type parameter typoIan Lance Taylor
Change-Id: Icff5f64231f937e9261c42030766e21768f5d430 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/240340 Reviewed-by: Rob Pike <r@golang.org>
2020-06-22design/go2draft-type-parameters: use func, not type, for methodIan Lance Taylor
Pointed out by Cornelius Diekmann. Change-Id: I419e220f4320fb3beebe313697d4bb5c3615c6c8 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/239417 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-06-22design/go2draft-type-parameters: add parameterized methods notesIan Lance Taylor
Change-Id: I1527928f5fd6550e366faa88527e7281483b3846 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/239169 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-06-22design/go2draft-type-parameters: fix typoIan Lance Taylor
Change-Id: I720b9241aff65296222095d83ea967a176d07a42 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/239165 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-06-20design/go2draft-type-parameters: fix typoIan Lance Taylor
Change-Id: If7434b7d2a111812047fd9c9cb95ff65aa2c50db Reviewed-on: https://go-review.googlesource.com/c/proposal/+/239157 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-06-20design/go2draft-type-parameters: fix typoDan Kortschak
Change-Id: Id468d065c574ce7913063a31bf0256100b29a763 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/238417 Reviewed-by: Toshihiro Shiino <shiino.toshihiro@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-06-20design/go2draft-type-parameters: fix cross-reference anchor linksTobias Klauser
When linking to heading anchors, replace spaces by - in the anchor. This will lead to the links being shown properly e.g. with the go.googlesource.com and GitHub Markdown renderers. Change-Id: Ib32dc08128d0c146e8ce8b2fbea7115357f82cc1 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/238397 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-06-16design/go2draft-contracts: mark as supersededIan Lance Taylor
Change-Id: If7c663992ceb503af12f3f8d41213908373fdab5 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/238004 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-06-16design: add go2draft-type-parameters.mdIan Lance Taylor
For golang/go#15292 Change-Id: I3c1dc1ffbc2e5df958f93dcb0d7a89a88f6b5107 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/238003 Reviewed-by: Robert Griesemer <gri@golang.org>
2020-06-12design/36606-64-bit-field-alignment: add proposalDan Scales
This change adds a new design proposal to the repository describing changes to Go alignment behavior and addition of Go directives, as a way to deal with the problems associated with issue golang/go#599. Updates golang/go#36606 Change-Id: I2b09424a71d2ffed7136205756f6e101aafd13bb Reviewed-on: https://go-review.googlesource.com/c/proposal/+/237317 Reviewed-by: Austin Clements <austin@google.com>
2020-04-08design/37112-unstable-runtime-metrics.md: incorporate feedbackMichael Anthony Knyszek
This change updates the proposal to incorporate feedback, namely: * Make Histogram a concrete type, and add a float64 version. * Change metric names to be paths with [a-z-]+ components. * Update all proposed metric names and add some new ones. * Update distribution metric names. * Replace the Value field in Sample with a reflect.Value-like type, which has a type tag. * Include the type tag of the metric's sample value in the description. * Add section about documentation and human discoverability of metrics. * Rename Descriptions() to All(). * Remove ValueSum from the Histogram due to the potential for overflow/underflow issues. * Use "description" over "descriptor" consistently. Change-Id: I99b812b6730c98b56a2796cae6993251b307d0f1 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/224397 Reviewed-by: Austin Clements <austin@google.com>
2020-03-18design/37112-unstable-runtime-metrics.md: add proposalMichael Anthony Knyszek
This change adds a proposal and design document for addition of a runtime metrics package which is designed to support adding and removing runtime metrics without breaking the Go 1 compatibility promise. Updates golang/go#37112. Change-Id: I550740970ad74c5c71d712735e4984808bdbf463 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/218677 Reviewed-by: Austin Clements <austin@google.com>
2020-03-1336460-lazy-module-loading: relax redundant 'go.mod' loads and add another ↵Bryan C. Mills
example We only need to load the full transitive dependencies of 'go 1.14' dependencies when we are performing a deepening scan. When we're just loading the go.mod file for redundancy, we should eliminate the overhead of that transitive loading. Updates golang/go#36460 Change-Id: I589d82640f7badead0f80c392109720804d2c242 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/222245 Reviewed-by: Jay Conrod <jayconrod@google.com>
2020-03-10design: add proposal doc for 33974Adrien Delorme
Make the `cmd/internal/lockedfile` Package public. Updates golang/go#33974 Change-Id: I2502fad153254d9ddb2bcc96ed6d8ef163940add GitHub-Last-Rev: d6be79e2bc2e232ab1ed7990ec36219f8b427040 GitHub-Pull-Request: golang/proposal#21 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/201277 Reviewed-by: Bryan C. Mills <bcmills@google.com>
2020-03-09design: add 37720-gopls-workspaces.mdHeschi Kreinick
Updates #37720. Change-Id: I0e2ce635248957c540bc9d34103c44e40d1fecbc Reviewed-on: https://go-review.googlesource.com/c/proposal/+/222312 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-03-05design/36460: add design for lazy module loadingBryan C. Mills
Updates golang/go#36460 Updates golang/go#27900 Updates golang/go#26955 Updates golang/go#30831 Updates golang/go#32058 Updates golang/go#32380 Updates golang/go#32419 Updates golang/go#33370 Updates golang/go#33669 Updates golang/go#36369 Change-Id: I1d4644e3e8b4e688c2fc5a569312495e5072b7d7 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/220080 Reviewed-by: Russ Cox <rsc@golang.org>
2020-03-02go2-language-changes: fix markdown typoTzach Shabtay
Change-Id: Ibc8f78202cb3626a5d7f2023c17cb6ef3a43968d GitHub-Last-Rev: 6e478e1b6c38f623a8670216a48494d3d7d1173e GitHub-Pull-Request: golang/proposal#23 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/221837 Reviewed-by: Ian Lance Taylor <iant@golang.org>
2020-02-27design/go2draft-contracts.md: document struct embedding parsing ambiguityRobert Griesemer
Change-Id: Iae16bc6735a7e59e7ff06b12ffbd2d137f4d1598 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/221257 Reviewed-by: Ian Lance Taylor <iant@golang.org>