| Age | Commit message (Collapse) | Author |
|
Copied from discussion at https://github.com/golang/go/discussions/55090#discussioncomment-3657405.
Change-Id: Id1be169e1c172629882d3b6e5b671765eecfa952
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/453498
Reviewed-by: Russ Cox <rsc@golang.org>
|
|
Change-Id: Ia89ab416b1b631a47bc76f186a6832f25b3ca2e7
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/454018
Reviewed-by: Russ Cox <rsc@golang.org>
|
|
Change-Id: I8dd608c38e0454b1e0f8dee9fd62eac8c17f12f4
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/454017
Reviewed-by: Russ Cox <rsc@golang.org>
TryBot-Bypass: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
|
|
Update the proposal to reflect https://go.dev/cl/448716, which
made Logger a pointer type.
Change-Id: If72913e1c780d1a5e46314150f500dee042f1251
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/450035
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
|
|
Change-Id: I43c0016ff967be1bdd94f6a43818b54d9bf9b818
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/447157
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Bypass: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
|
|
Change-Id: I7629efed8d63a1973b7c3d4500d2afc8a096df32
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/446870
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
|
|
This design document is a modification of the top post of the GitHub
discussion on structured logging
(https://github.com/golang/go/discussions/54763).
Most of the document is unchanged, except for reformatting.
The section on contexts has been rewritten to accommodate the new
`WithContext` method and `Ctx` function, and the sections on groups
and the `LogValue` method have been added.
Change-Id: Ife6385c87c872c2a31c036ca63f8f61e6e2902a0
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/444415
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
|
|
For golang/go#55022.
Change-Id: I70ef39ee887026304f7e64e2747a580a0d717ee9
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/439297
Auto-Submit: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
|
|
For #44167.
Change-Id: Ifb77d37798842b7b31addebd8512a9272bd1a665
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/442784
Reviewed-by: Michael Knyszek <mknyszek@google.com>
|
|
This doc describes the proposed implementation details for the PGO design in 55022-pgo.md.
For golang/go#55022.
Change-Id: Ifa277419ec820fa5f18bf4d3220eeb0c41db1d07
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/430398
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
|
|
We propose adding support for profile-guided optimization (PGO) to
Go.
For golang/go#55022.
Change-Id: I9bf8afc4858a530bc32fc2b40698209a45695203
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/430355
Reviewed-by: Michael Pratt <mpratt@google.com>
|
|
This change updates the design document with some additional prior art
and corrections that reflect the final implementation.
For #48409.
Change-Id: I8276a30b546c698ab1c9f946ccc0ae2a327399d0
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/421418
Reviewed-by: Michael Knyszek <mknyszek@google.com>
|
|
In 2009, Google's open-source lawyers asked us to create the AUTHORS
file to define "The Go Authors", and the CONTRIBUTORS file was in
keeping with open source best practices of the time.
Re-reviewing our repos now in 2022, the open-source lawyers are
comfortable with source control history taking the place of the
AUTHORS file, and most open source projects no longer maintain
CONTRIBUTORS files.
To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.
For golang/go#53961.
Change-Id: Ie1a97697ae4499c59b8dfc46797013df993041e2
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/418921
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
|
|
A step toward gathering design docs in one place.
When this is submitted I will update the go.dev/s link.
Change-Id: Ib34d955fdcfad9ecded5ed323922e8eef7b49d90
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/417642
Reviewed-by: Rob Pike <r@golang.org>
|
|
A step toward gathering design docs in one place.
Change-Id: Ic4c0d2b27d4e91a30272b260c891cffe42c371e6
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/385794
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
|
|
fix some typos
Change-Id: Ic4290481cd7cb007aaec10cf4c67e61a2e7f57cd
GitHub-Last-Rev: 921891168b9f5ad12600dfda0bab95213b6f73c9
GitHub-Pull-Request: golang/proposal#46
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/411814
Reviewed-by: Than McIntosh <thanm@google.com>
|
|
More specific details on user-callable APIs for writing coverage data.
Updates golang/go#51430.
Change-Id: I9ebe2f20ee7fc6b37aadef7fd16dc97ee5b67da8
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/409994
Reviewed-by: Than McIntosh <thanm@google.com>
|
|
This is a copy of the original text from a Google Doc.
Change-Id: If5ff705124ba36a5d73789b7e6e419f0dc72fc7c
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/402415
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Rob Pike <r@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
|
|
Updates to proposal, including a description of how
hybrid instrumentation works.
Updates golang/go#51430.
Change-Id: I3a0b6c579b8d2f8e521bcbad8f9caf27c5999f09
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/404414
Reviewed-by: Than McIntosh <thanm@google.com>
|
|
These are needed to provide the old go/doc API faithfully.
For golang/go#51082.
Change-Id: I975551873fdfd5fccae51280300bff14f2059aee
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/398535
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
|
|
This change updates the scaling-the-page-allocator proposal to better
reflect the final implementation that ended up landing. It also updates
the "Prior Art" section with references to DieHard, DieHarder, and
Mesh, which are malloc/free implementations that notably use bitmaps as
a part of their implementation.
Updates golang/go#35112.
Change-Id: If584fca2a3928e3c7518d0a8df806809ca69c5e2
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/219121
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Trust: Michael Knyszek <mknyszek@google.com>
|
|
This change updates the GC pacer redesign design document to remove a
few inaccuracies and update two points that became apparent after
experimentation.
Firstly, the inaccuracies were mostly around what was ignored. For
instance, goroutines already donate their debt or credit back to the
global pool on death.
Secondly, the definition of the heap goal included S_n and G_n twice
erroneously. It was written that way with _overall_ GC-work-related
memory used in mind, but the definition is _just_ for heap memory.
Lastly, it turns out that the current pacer does (in its own indirect
way) account for idle priority GC in some way, and not accounting for it
in the new pacer leads to a performance regression. This change adds a
section describing how to account for it.
For golang/go#44167.
Change-Id: I396bbcb87fc3acd84584b10769e31d7da699fdb9
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/350429
Reviewed-by: Michael Knyszek <mknyszek@google.com>
|
|
Change-Id: Id635159df7eab01b64ff4a49fbe3268e3deb0f9b
GitHub-Last-Rev: 4eaaffe63ba378f1e4f0b72d24bd09c5f8ac81a5
GitHub-Pull-Request: golang/proposal#45
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/393994
Reviewed-by: Ian Lance Taylor <iant@golang.org>
|
|
Change-Id: I55decc8d53df8ebc5e3b9873dde4d2797191965f
GitHub-Last-Rev: b3974d062ed2195b985d1b551466dfe4a5837ae4
GitHub-Pull-Request: golang/proposal#44
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/393975
Reviewed-by: Ian Lance Taylor <iant@golang.org>
|
|
Correct the markdown syntax for the second link in the "Generics Implementation - GC Shape Stenciling" document.
This addresses a typo recently introduced in CL 387214.
Change-Id: I96f743b8ebd32ad0ee37118182ddce6161eafbc5
GitHub-Last-Rev: 1a666c4e4385c6c305ef53fed824a88eb240fd53
GitHub-Pull-Request: golang/proposal#43
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/390454
Reviewed-by: Ian Lance Taylor <iant@golang.org>
|
|
Detailed design document for proposal golang/go#51430, revamping
code coverage testing.
Updates golang/go#51430.
Change-Id: I692c6c6f977b9e4e14a6c4cc5fbd086d53021c27
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/388857
Trust: Than McIntosh <thanm@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
|
|
Change-Id: Iceb2d96c973c09617ad6edaa4b25e98bb4d65231
GitHub-Last-Rev: dba13441f8ed9418985f1baf3f87f06e46fc0215
GitHub-Pull-Request: golang/proposal#41
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/388734
Reviewed-by: Ian Lance Taylor <iant@golang.org>
|
|
Change-Id: Ib12cd3b6883737fe2494d44c8b369e8816e012cd
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/387214
Reviewed-by: Keith Randall <khr@golang.org>
|
|
Change-Id: I6d56cf8ac019ce383b856be5e7cfec8b532173ad
GitHub-Last-Rev: 7349441d7f457f83c00b3820441c010719c99c68
GitHub-Pull-Request: golang/proposal#40
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/386318
Reviewed-by: Ian Lance Taylor <iant@golang.org>
|
|
Change-Id: I532ae825ee7c48909ff53137669ffe80caf5fcf3
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/384434
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
|
|
Sigh.
Change-Id: I771d6c075400c83a90b140402257a349fe2ae7a8
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/384163
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
|
|
Change-Id: I60131c0a5c7d1b18c4733a4e75e28180dfd1447a
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/384162
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
|
|
Thanks to Manlio Perillo for pointing this out.
Change-Id: I6df29da2810362a6ba51635afbfbe3ab20a010f0
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/379919
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
|
|
Change-Id: I85e10a664dc91d526d84f76f3c8e00ab221567c5
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/365714
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
|
|
Reported by Manlio Perillo.
Change-Id: I16956b6d8983c5eb72bedf7fc8803f633bb15e4a
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/379954
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
|
|
The actual constraints package has the latter but not the former.
Change-Id: I9377c43c4421fde50823119bb3c7b165470e8736
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/379614
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
|
|
Change-Id: I4ee372e5c738c2b4ad9aa1f2b2e4c0ca7c157bec
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/372454
Trust: Michael Matloob <matloob@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
|
|
and Underlying
Update the go/types type parameter API proposal to include a final set
of changes:
- implicit interfaces
- any outside of constraint position
- changes to type parameter Underlying
- addition of TypeParam.Index
I believe this brings the proposal up-to-date for 1.18.
Fixes golang/go#47916
Change-Id: Ie914d6e42a7adff705a4da81139656cce49443d7
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/368956
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
|
|
Change-Id: Ic42e1113c96b087badcb3dcbe6ebd0a6a3460a7d
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/367414
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
|
|
Change-Id: Ifb4c3bcdc382d64b469616f311399af6fbe180f1
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/366014
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
|
|
This change doesn't include a full review of
the text, nor make any attempts to get it fully
up-to-date with reality today. However, it's
important that our documents, including
historical ones, are consistent in their
terminology.
Updates golang/go#49185
Change-Id: I194d518e10a46e6e3378a381fb3549846f8bca9e
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/363515
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
|
|
Change-Id: I3f8e9b0b4654c0130b22d2ca8024b85688218f15
GitHub-Last-Rev: 6188088ecd0ec22ecae470615e87ece2e3bca397
GitHub-Pull-Request: golang/proposal#37
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/360609
Reviewed-by: Ian Lance Taylor <iant@golang.org>
|
|
Change-Id: Id64bf406cfc39e9d0fa1114e7b0614b1cdaef94f
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/354449
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
|
|
Update the go/types type parameter API proposal to include recent
changes:
- Replacing setters with `NewSignatureType`
- Replacing IsConstraint with IsMethodSet
- Renaming Environment to Context
Updates golang/go#47916
Change-Id: I8735bbebb79ca9606bd87176770b07621b20180f
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/353829
Reviewed-by: Robert Findley <rfindley@google.com>
|
|
Change-Id: I3eba2d2d24c23d8c9e371ea1a123be32ae84cbaa
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/352114
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
|
|
Change-Id: Ic581342166946e9c2be5c338e2cc3a6193f3a5ed
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/351833
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
|
|
Update ArgumentError following CL 351335.
Change-Id: I93f96529b2795ae5b030099c0ea41ecdbd6373af
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/351350
Reviewed-by: Robert Findley <rfindley@google.com>
|
|
Change-Id: I0739388b25b22b96d508fad3b452e3e6d81aff63
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/351349
Reviewed-by: Robert Findley <rfindley@google.com>
Trust: Robert Findley <rfindley@google.com>
|
|
For golang/go#48409.
Change-Id: I4e5d6d117982f51108dca83a8e59b118c2b6f4bf
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/350116
Reviewed-by: Michael Pratt <mpratt@google.com>
|
|
Change-Id: I73cd7f2549d5d4dbe6f55fef5620b72f9c65059e
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/350849
Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Alberto Donizetti <alb.donizetti@gmail.com>
|