From 387a005b608d47466adfb75fec24ef8a743022f6 Mon Sep 17 00:00:00 2001 From: Jonathan Amsterdam Date: Wed, 11 Aug 2021 10:04:52 -0400 Subject: internal/postgres: rename function For golang/go#47555 Change-Id: I9e90de83d441748e70b0992f3a31a02f46f1bce9 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/341429 Trust: Jonathan Amsterdam Run-TryBot: Jonathan Amsterdam Reviewed-by: Jamal Carvalho TryBot-Result: kokoro --- internal/postgres/search.go | 10 +++++----- internal/postgres/search_test.go | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'internal/postgres') diff --git a/internal/postgres/search.go b/internal/postgres/search.go index 56376bb2..fc788ede 100644 --- a/internal/postgres/search.go +++ b/internal/postgres/search.go @@ -1088,7 +1088,7 @@ func (db *DB) DeleteOlderVersionFromSearchDocuments(ctx context.Context, moduleP } // Delete all of those paths. - return deleteModuleFromSearchDocuments(ctx, tx, modulePath, ppaths) + return deleteModuleOrPackagesInModuleFromSearchDocuments(ctx, tx, modulePath, ppaths) }) } @@ -1111,12 +1111,12 @@ func deleteOtherModulePackagesFromSearchDocuments(ctx context.Context, tx *datab otherPkgs = append(otherPkgs, p) } } - return deleteModuleFromSearchDocuments(ctx, tx, m.ModulePath, otherPkgs) + return deleteModuleOrPackagesInModuleFromSearchDocuments(ctx, tx, m.ModulePath, otherPkgs) } -// deleteModuleFromSearchDocuments deletes module_path from search_documents. -// If packages is non-empty, it only deletes those packages. -func deleteModuleFromSearchDocuments(ctx context.Context, tx *database.DB, modulePath string, packages []string) error { +// deleteModuleOrPackagesInModuleFromSearchDocuments deletes module_path from +// search_documents. If packages is non-empty, it only deletes those packages. +func deleteModuleOrPackagesInModuleFromSearchDocuments(ctx context.Context, tx *database.DB, modulePath string, packages []string) error { d := squirrel.Delete("search_documents"). Where(squirrel.Eq{"module_path": modulePath}) if len(packages) > 0 { diff --git a/internal/postgres/search_test.go b/internal/postgres/search_test.go index 5383ff14..21904656 100644 --- a/internal/postgres/search_test.go +++ b/internal/postgres/search_test.go @@ -1377,7 +1377,7 @@ func TestDeleteFromSearch(t *testing.T) { defer release() insertInitial(testDB) - if err := deleteModuleFromSearchDocuments(ctx, testDB.db, modulePath, nil); err != nil { + if err := deleteModuleOrPackagesInModuleFromSearchDocuments(ctx, testDB.db, modulePath, nil); err != nil { t.Fatal(err) } checkSearchDocuments(ctx, t, testDB, []searchDocumentRow{ -- cgit v1.3-5-g9baa