diff options
| author | Ethan Lee <ethanalee@google.com> | 2026-02-18 16:21:45 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2026-02-18 11:02:48 -0800 |
| commit | 751b73c25d80fb9a0a21e157772d1529aa549b32 (patch) | |
| tree | 6dc40b0811b91525dc42f2e8bc54b6fe4f1d6e6e | |
| parent | ce44214c045bc223217f4e969a2b2d3f249b7c21 (diff) | |
| download | go-x-pkgsite-751b73c25d80fb9a0a21e157772d1529aa549b32.tar.xz | |
internal/godoc: remove parser.ParseDir usage in encode_test
- staticcheck was causing a kokoro build failure. Removed the deprecated
API in favor of using an os.ReadDir loop and parser.ParseFile.
Fixes golang/go#77682
Change-Id: Ie0f39298b2854b38014e58cb24ed0b496eaadf70
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/746620
Reviewed-by: Sean Liao <sean@liao.dev>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Nicholas Husin <nsh@golang.org>
Auto-Submit: Ethan Lee <ethanalee@google.com>
Reviewed-by: Nicholas Husin <husin@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
| -rw-r--r-- | internal/godoc/encode_test.go | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/internal/godoc/encode_test.go b/internal/godoc/encode_test.go index 775765b9..1e6ef86c 100644 --- a/internal/godoc/encode_test.go +++ b/internal/godoc/encode_test.go @@ -12,6 +12,7 @@ import ( "go/parser" "go/token" "io" + "os" "path/filepath" "reflect" "sort" @@ -89,15 +90,20 @@ func main() { a = 1 } func packageForDir(dir string, removeNodes bool) (*Package, error) { fset := token.NewFileSet() - pkgs, err := parser.ParseDir(fset, dir, nil, parser.ParseComments) + des, err := os.ReadDir(dir) if err != nil { return nil, err } p := NewPackage(fset, nil) - for _, pkg := range pkgs { - for _, f := range pkg.Files { - p.AddFile(f, removeNodes) + for _, de := range des { + if de.IsDir() || !strings.HasSuffix(de.Name(), ".go") { + continue } + f, err := parser.ParseFile(fset, filepath.Join(dir, de.Name()), nil, parser.ParseComments) + if err != nil { + return nil, err + } + p.AddFile(f, removeNodes) } return p, nil } |