diff options
| author | Roland Shoemaker <roland@golang.org> | 2023-11-09 11:51:11 -0800 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-11-09 20:53:37 +0000 |
| commit | a2edfb50727c2b04a93ccc2f0f7931a02fb623d7 (patch) | |
| tree | a52e5a4c78bdd8c5ce2eae4d2f613fb6faa6e73f /ssh/server.go | |
| parent | ff15cd57d18f87d81a83bf288597042b2e50aaef (diff) | |
| download | go-x-crypto-a2edfb50727c2b04a93ccc2f0f7931a02fb623d7.tar.xz | |
cryptobyte: fix ReadOptionalASN1Boolean
ReadOptionalASN1Boolean was completely broken, it would only work when
there were two BOOLEAN fields in a row, with the first being OPTIONAL
(which is itself invalid ASN.1 due to the ambiguity). This fixes it
to properly expect a BOOLEAN wrapped in a context-specific tag, as is
the case for all of the other ReadOptionalASN1* methods, and updates
its doc string.
This is a breaking change as it requires adding the tag field to
properly support context-specific tags. Given the method would
previously not work this seems like a reasonable breakage.
Fixes golang/go#43019
Change-Id: I42398256216c59988e249c90bc7aa668f64df945
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/274242
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Roland Shoemaker <roland@golang.org>
Diffstat (limited to 'ssh/server.go')
0 files changed, 0 insertions, 0 deletions