diff options
| author | Neal Patel <nealpatel@google.com> | 2026-01-27 21:32:36 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2026-03-10 10:37:09 -0700 |
| commit | 159944f128e9b3fdeb5a5b9b102a961904601a87 (patch) | |
| tree | ecb65c74db2b73ca81d1387af1e393a20876bf54 | |
| parent | a408498e55412f2ae2a058336f78889fb1ba6115 (diff) | |
| download | go-x-crypto-159944f128e9b3fdeb5a5b9b102a961904601a87.tar.xz | |
ssh,acme: clean up tautological/impossible nil conditions
Change-Id: I4c6b4b6d8dc1e8a9d2ebfb8d350b7617d3cf7949
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/739780
Auto-Submit: Neal Patel <nealpatel@google.com>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Nicola Murino <nicola.murino@gmail.com>
| -rw-r--r-- | acme/autocert/renewal_test.go | 3 | ||||
| -rw-r--r-- | ssh/agent/server.go | 2 | ||||
| -rw-r--r-- | ssh/certs_test.go | 4 |
3 files changed, 1 insertions, 8 deletions
diff --git a/acme/autocert/renewal_test.go b/acme/autocert/renewal_test.go index 67e2da2..14607b8 100644 --- a/acme/autocert/renewal_test.go +++ b/acme/autocert/renewal_test.go @@ -180,9 +180,6 @@ func TestRenewFromCacheAlreadyRenewed(t *testing.T) { // set internal state to an almost expired cert oldCert := ca.LeafCert(exampleDomain, "ECDSA", now.Add(-2*time.Hour), now.Add(time.Minute)) - if err != nil { - t.Fatal(err) - } oldLeaf, err := validCert(exampleCertKey, oldCert.Certificate, oldCert.PrivateKey.(crypto.Signer), now) if err != nil { t.Fatal(err) diff --git a/ssh/agent/server.go b/ssh/agent/server.go index 4e8ff86..2a7658c 100644 --- a/ssh/agent/server.go +++ b/ssh/agent/server.go @@ -36,7 +36,7 @@ func (s *server) processRequestBytes(reqData []byte) []byte { return []byte{agentFailure} } - if err == nil && rep == nil { + if rep == nil { return []byte{agentSuccess} } diff --git a/ssh/certs_test.go b/ssh/certs_test.go index ba435ab..51fbf88 100644 --- a/ssh/certs_test.go +++ b/ssh/certs_test.go @@ -330,10 +330,6 @@ func TestCertTypes(t *testing.T) { go NewServerConn(c1, conf) priv := m.signer - if err != nil { - t.Fatalf("error generating ssh pubkey: %v", err) - } - cert := &Certificate{ CertType: UserCert, Key: priv.PublicKey(), |