From d731f0ade129a71237eff5a17f3196002cb439fb Mon Sep 17 00:00:00 2001 From: Jeff King Date: Wed, 23 Jan 2013 01:24:23 -0500 Subject: convert some config callbacks to parse_config_key These callers can drop some inline pointer arithmetic and magic offset constants, making them more readable and less error-prone (those constants had to match the lengths of strings, but there is no automatic verification of that fact). The "ep" pointer (presumably for "end pointer"), which points to the final key segment of the config variable, is given the more standard name "key" to describe its function rather than its derivation. Signed-off-by: Jeff King Reviewed-by: Jonathan Nieder Signed-off-by: Junio C Hamano --- userdiff.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) (limited to 'userdiff.c') diff --git a/userdiff.c b/userdiff.c index ed958ef6b8..a4ea1e97b7 100644 --- a/userdiff.c +++ b/userdiff.c @@ -188,20 +188,13 @@ static struct userdiff_driver *parse_driver(const char *var, const char *value, const char *type) { struct userdiff_driver *drv; - const char *dot; - const char *name; + const char *name, *key; int namelen; - if (prefixcmp(var, "diff.")) - return NULL; - dot = strrchr(var, '.'); - if (dot == var + 4) - return NULL; - if (strcmp(type, dot+1)) + if (parse_config_key(var, "diff", &name, &namelen, &key) < 0 || + !name || strcmp(type, key)) return NULL; - name = var + 5; - namelen = dot - name; drv = userdiff_find_by_namelen(name, namelen); if (!drv) { ALLOC_GROW(drivers, ndrivers+1, drivers_alloc); -- cgit v1.3