From 0527ccb1b558e1337f5f3e02ea9747d86a1908a8 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Tue, 30 Nov 2021 14:14:15 +0000 Subject: add -i: default to the built-in implementation In 9a5315edfdf (Merge branch 'js/patch-mode-in-others-in-c', 2020-02-05), Git acquired a built-in implementation of `git add`'s interactive mode that could be turned on via the config option `add.interactive.useBuiltin`. The first official Git version to support this knob was v2.26.0. In 2df2d81ddd0 (add -i: use the built-in version when feature.experimental is set, 2020-09-08), this built-in implementation was also enabled via `feature.experimental`. The first version with this change was v2.29.0. More than a year (and very few bug reports) later, it is time to declare the built-in implementation mature and to turn it on by default. We specifically leave the `add.interactive.useBuiltin` configuration in place, to give users an "escape hatch" in the unexpected case should they encounter a previously undetected bug in that implementation. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- t/README | 2 +- t/t2016-checkout-patch.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 't') diff --git a/t/README b/t/README index 29f72354bf..2c22337d6e 100644 --- a/t/README +++ b/t/README @@ -419,7 +419,7 @@ the --sparse command-line argument. GIT_TEST_PRELOAD_INDEX= exercises the preload-index code path by overriding the minimum number of cache entries required per thread. -GIT_TEST_ADD_I_USE_BUILTIN=, when true, enables the +GIT_TEST_ADD_I_USE_BUILTIN=, when false, disables the built-in version of git add -i. See 'add.interactive.useBuiltin' in git-config(1). diff --git a/t/t2016-checkout-patch.sh b/t/t2016-checkout-patch.sh index 71c5a15be0..bc3f69b4b1 100755 --- a/t/t2016-checkout-patch.sh +++ b/t/t2016-checkout-patch.sh @@ -4,7 +4,7 @@ test_description='git checkout --patch' . ./lib-patch-mode.sh -if ! test_bool_env GIT_TEST_ADD_I_USE_BUILTIN false && ! test_have_prereq PERL +if ! test_bool_env GIT_TEST_ADD_I_USE_BUILTIN true && ! test_have_prereq PERL then skip_all='skipping interactive add tests, PERL not set' test_done -- cgit v1.3