From 7eb5bbdb645e04d746bc0edea102744f50a5e529 Mon Sep 17 00:00:00 2001 From: Adeodato Simó Date: Fri, 9 Jan 2009 18:30:05 +0100 Subject: t7501-commit.sh: explicitly check that -F prevents invoking the editor MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The "--signoff" test case in t7500-commit.sh was setting VISUAL while using -F -, which indeed tested that the editor is not spawned with -F. However, having it there was confusing, since there was no obvious reason to the casual reader for it to be there. This commits removes the setting of VISUAL from the --signoff test, and adds in t7501-commit.sh a dedicated test case, where the rest of tests for -F are. Signed-off-by: Adeodato Simó Okay-then-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- t/t7500-commit.sh | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 't/t7500-commit.sh') diff --git a/t/t7500-commit.sh b/t/t7500-commit.sh index 6e18a96319..5998baf27b 100755 --- a/t/t7500-commit.sh +++ b/t/t7500-commit.sh @@ -149,10 +149,7 @@ EOF test_expect_success '--signoff' ' echo "yet another content *narf*" >> foo && - echo "zort" | ( - test_set_editor "$TEST_DIRECTORY"/t7500/add-content && - git commit -s -F - foo - ) && + echo "zort" | git commit -s -F - foo && git cat-file commit HEAD | sed "1,/^$/d" > output && test_cmp expect output ' -- cgit v1.3-5-g9baa