From d9e6d0942bb9f9fe9e4cca9670181e5b59074bcb Mon Sep 17 00:00:00 2001 From: Matthew DeVore Date: Fri, 12 Oct 2018 13:01:41 -0700 Subject: filter-trees: code clean-up of tests A few trivial updates to test to match the current best practices. - avoid "grep -q" that strips potentially useful output from tests running under "-v". - use test_write_lines to prepare multi-line expected output file. - reserve use of test_must_fail to "git" commands. Signed-off-by: Matthew DeVore Signed-off-by: Junio C Hamano --- t/t5317-pack-objects-filter-objects.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 't/t5317-pack-objects-filter-objects.sh') diff --git a/t/t5317-pack-objects-filter-objects.sh b/t/t5317-pack-objects-filter-objects.sh index 510d3537f6..d9dccf4d4d 100755 --- a/t/t5317-pack-objects-filter-objects.sh +++ b/t/t5317-pack-objects-filter-objects.sh @@ -69,7 +69,7 @@ test_expect_success 'get an error for missing tree object' ' test_must_fail git -C r5 pack-objects --rev --stdout 2>bad_tree <<-EOF && HEAD EOF - grep -q "bad tree object" bad_tree + grep "bad tree object" bad_tree ' test_expect_success 'setup for tests of tree:0' ' -- cgit v1.3-5-g45d5