From 14c0ea0f6f7a0898214d8fa822a2392ef3a00f53 Mon Sep 17 00:00:00 2001 From: Patrick Steinhardt Date: Thu, 5 Sep 2024 12:09:15 +0200 Subject: shallow: free grafts when unregistering them When removing a graft via `unregister_shallow()` we remove it from the grafts array, but do not free the structure. Fix this to plug the leak. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano --- shallow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'shallow.c') diff --git a/shallow.c b/shallow.c index a10cf9e9d5..7e0ee96ead 100644 --- a/shallow.c +++ b/shallow.c @@ -51,10 +51,12 @@ int unregister_shallow(const struct object_id *oid) int pos = commit_graft_pos(the_repository, oid); if (pos < 0) return -1; - if (pos + 1 < the_repository->parsed_objects->grafts_nr) + if (pos + 1 < the_repository->parsed_objects->grafts_nr) { + free(the_repository->parsed_objects->grafts[pos]); MOVE_ARRAY(the_repository->parsed_objects->grafts + pos, the_repository->parsed_objects->grafts + pos + 1, the_repository->parsed_objects->grafts_nr - pos - 1); + } the_repository->parsed_objects->grafts_nr--; return 0; } -- cgit v1.3