From a7ff6f5a0f310406aa4973e8d7ec25815554bcb5 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Fri, 10 Aug 2018 19:09:44 -0400 Subject: for_each_*_object: take flag arguments as enum It's not wrong to pass our flags in an "unsigned", as we know it will be at least as large as the enum. However, using the enum in the declaration makes it more obvious where to find the list of flags. While we're here, let's also drop the "extern" noise-words from the declarations, per our modern coding style. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- sha1-file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'sha1-file.c') diff --git a/sha1-file.c b/sha1-file.c index dfa8a35d68..cc0b57a751 100644 --- a/sha1-file.c +++ b/sha1-file.c @@ -2146,7 +2146,8 @@ static int loose_from_alt_odb(struct alternate_object_database *alt, return r; } -int for_each_loose_object(each_loose_object_fn cb, void *data, unsigned flags) +int for_each_loose_object(each_loose_object_fn cb, void *data, + enum for_each_object_flags flags) { struct loose_alt_odb_data alt; int r; -- cgit v1.3-5-g9baa