From a3d1f391d35762162356201028fb73774a6c4a8b Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Thu, 15 Jan 2026 11:12:53 -0800 Subject: Revert "Merge branch 'ar/run-command-hook'" This reverts commit f406b8955295d01089ba2baf35eceadff2d11cae, reversing changes made to 1627809eeff75e6ec936fc609e7be46d5eb2fa9e. It seems to have caused a few regressions, two of the three known ones we have proposed solutions for. Let's give ourselves a bit more room to maneuver during the pre-release freeze period and restart once the 2.53 ships. --- run-command.h | 38 -------------------------------------- 1 file changed, 38 deletions(-) (limited to 'run-command.h') diff --git a/run-command.h b/run-command.h index 7093252863..0df25e445f 100644 --- a/run-command.h +++ b/run-command.h @@ -420,32 +420,6 @@ typedef int (*start_failure_fn)(struct strbuf *out, void *pp_cb, void *pp_task_cb); -/** - * This callback is repeatedly called on every child process who requests - * start_command() to create a pipe by setting child_process.in < 0. - * - * pp_cb is the callback cookie as passed into run_processes_parallel, and - * pp_task_cb is the callback cookie as passed into get_next_task_fn. - * - * Returns < 0 for error - * Returns == 0 when there is more data to be fed (will be called again) - * Returns > 0 when finished (child closed fd or no more data to be fed) - */ -typedef int (*feed_pipe_fn)(int child_in, - void *pp_cb, - void *pp_task_cb); - -/** - * If this callback is provided, output is collated into a new pipe instead - * of the process stderr. Then `consume_output_fn` will be called repeatedly - * with output contained in the `output` arg. It will also be called with an - * empty `output` to allow for keepalives or similar operations if necessary. - * - * pp_cb is the callback cookie as passed into run_processes_parallel. - * No task cookie is provided because the callback receives collated output. - */ -typedef void (*consume_output_fn)(struct strbuf *output, void *pp_cb); - /** * This callback is called on every child process that finished processing. * @@ -499,18 +473,6 @@ struct run_process_parallel_opts */ start_failure_fn start_failure; - /* - * feed_pipe: see feed_pipe_fn() above. This can be NULL to omit any - * special handling. - */ - feed_pipe_fn feed_pipe; - - /* - * consume_output: see consume_output_fn() above. This can be NULL - * to omit any special handling. - */ - consume_output_fn consume_output; - /** * task_finished: See task_finished_fn() above. This can be * NULL to omit any special handling. -- cgit v1.3