From f1178380ac645684fcf0519488f9336e55f0946f Mon Sep 17 00:00:00 2001 From: Derrick Stolee Date: Tue, 6 Jun 2023 13:24:36 +0000 Subject: replace-objects: create wrapper around setting The 'read_replace_objects' constant is initialized by git_default_config (if core.useReplaceRefs is disabled) and within setup_git_env (if GIT_NO_REPLACE_OBJECTS) is set. To ensure that this variable cannot be set accidentally in other places, wrap it in a replace_refs_enabled() method. Since we still assign this global in config.c, we are not able to remove the global scope of this variable and make it a static within replace-object.c. This will happen in a later change which will also prevent the variable from being read before it is initialized. Centralizing read access to the variable is an important first step. Signed-off-by: Derrick Stolee Signed-off-by: Junio C Hamano --- replace-object.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'replace-object.c') diff --git a/replace-object.c b/replace-object.c index ceec81c940..07cfedd6df 100644 --- a/replace-object.c +++ b/replace-object.c @@ -89,3 +89,8 @@ void disable_replace_refs(void) { read_replace_refs = 0; } + +int replace_refs_enabled(struct repository *r) +{ + return read_replace_refs; +} -- cgit v1.3