From 044b6f04f23d6c7e3c3750c9829db96b71470874 Mon Sep 17 00:00:00 2001 From: Meet Soni Date: Sat, 15 Feb 2025 14:15:39 +0530 Subject: refspec: clarify function naming and documentation Rename `match_name_with_pattern()` to `match_refname_with_pattern()` to better reflect its purpose and improve documentation comment clarity. The previous function name and parameter names were inconsistent, making it harder to understand their roles in refspec matching. - Rename parameters: - `key` -> `pattern` (globbing pattern to match) - `name` -> `refname` (refname to check) - `value` -> `replacement` (replacement mapping pattern) Signed-off-by: Meet Soni Signed-off-by: Junio C Hamano --- refspec.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'refspec.h') diff --git a/refspec.h b/refspec.h index f62f83a7ee..e2b5cc54ef 100644 --- a/refspec.h +++ b/refspec.h @@ -75,11 +75,12 @@ void refspec_ref_prefixes(const struct refspec *rs, int refname_matches_negative_refspec_item(const char *refname, struct refspec *rs); /* - * Checks whether a name matches a pattern and optionally generates a result. - * Returns 1 if the name matches the pattern, 0 otherwise. + * Checks if a refname matches a globbing refspec pattern. + * If replacement is provided, computes the corresponding mapped refname. + * Returns 1 if refname matches pattern, 0 otherwise. */ -int match_name_with_pattern(const char *key, const char *name, - const char *value, char **result); +int match_refname_with_pattern(const char *pattern, const char *refname, + const char *replacement, char **result); /* * Queries a refspec for a match and updates the query item. -- cgit v1.3