From ef5ddb2fe0cdb3bd09acb7229512b6ae9193423f Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Sat, 30 Dec 2006 23:28:53 -0500 Subject: Use PATH_MAX constant for --bare. For easier portability we prefer PATH_MAX over seemingly random constants like 1024. Make it so. Signed-off-by: Shawn O. Pearce Signed-off-by: Junio C Hamano --- git.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'git.c') diff --git a/git.c b/git.c index 50ebd869ad..ec897dc88c 100644 --- a/git.c +++ b/git.c @@ -69,8 +69,8 @@ static int handle_options(const char*** argv, int* argc) } else if (!strncmp(cmd, "--git-dir=", 10)) { setenv("GIT_DIR", cmd + 10, 1); } else if (!strcmp(cmd, "--bare")) { - static char git_dir[1024]; - setenv("GIT_DIR", getcwd(git_dir, 1024), 1); + static char git_dir[PATH_MAX+1]; + setenv("GIT_DIR", getcwd(git_dir, sizeof(git_dir)), 1); } else { fprintf(stderr, "Unknown option: %s\n", cmd); usage(git_usage_string); -- cgit v1.3 From 45b097947d6297a4b3f1016b05c66cdc15b411c2 Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Sat, 30 Dec 2006 23:29:11 -0500 Subject: Replace "GIT_DIR" with GIT_DIR_ENVIRONMENT. We tend to use the nice constant GIT_DIR_ENVIRONMENT when we are referring to the "GIT_DIR" constant, but git.c didn't do so. Now it does. Signed-off-by: Shawn O. Pearce Signed-off-by: Junio C Hamano --- git.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'git.c') diff --git a/git.c b/git.c index ec897dc88c..c82ca458e4 100644 --- a/git.c +++ b/git.c @@ -63,14 +63,14 @@ static int handle_options(const char*** argv, int* argc) fprintf(stderr, "No directory given for --git-dir.\n" ); usage(git_usage_string); } - setenv("GIT_DIR", (*argv)[1], 1); + setenv(GIT_DIR_ENVIRONMENT, (*argv)[1], 1); (*argv)++; (*argc)--; } else if (!strncmp(cmd, "--git-dir=", 10)) { - setenv("GIT_DIR", cmd + 10, 1); + setenv(GIT_DIR_ENVIRONMENT, cmd + 10, 1); } else if (!strcmp(cmd, "--bare")) { static char git_dir[PATH_MAX+1]; - setenv("GIT_DIR", getcwd(git_dir, sizeof(git_dir)), 1); + setenv(GIT_DIR_ENVIRONMENT, getcwd(git_dir, sizeof(git_dir)), 1); } else { fprintf(stderr, "Unknown option: %s\n", cmd); usage(git_usage_string); -- cgit v1.3