From afe8a9070bc62db9cfde1e30147178c40d391d93 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Mon, 2 May 2022 09:50:37 -0700 Subject: tree-wide: apply equals-null.cocci Signed-off-by: Junio C Hamano --- compat/mingw.c | 6 +++--- compat/mkdir.c | 2 +- compat/mmap.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) (limited to 'compat') diff --git a/compat/mingw.c b/compat/mingw.c index 5e42191fa4..36ef632904 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -1043,7 +1043,7 @@ char *mingw_mktemp(char *template) int mkstemp(char *template) { char *filename = mktemp(template); - if (filename == NULL) + if (!filename) return -1; return open(filename, O_RDWR | O_CREAT, 0600); } @@ -2311,7 +2311,7 @@ int setitimer(int type, struct itimerval *in, struct itimerval *out) static const struct timeval zero; static int atexit_done; - if (out != NULL) + if (out) return errno = EINVAL, error("setitimer param 3 != NULL not implemented"); if (!is_timeval_eq(&in->it_interval, &zero) && @@ -2340,7 +2340,7 @@ int sigaction(int sig, struct sigaction *in, struct sigaction *out) if (sig != SIGALRM) return errno = EINVAL, error("sigaction only implemented for SIGALRM"); - if (out != NULL) + if (out) return errno = EINVAL, error("sigaction: param 3 != NULL not implemented"); diff --git a/compat/mkdir.c b/compat/mkdir.c index 9e253fb72f..02aea3b32e 100644 --- a/compat/mkdir.c +++ b/compat/mkdir.c @@ -9,7 +9,7 @@ int compat_mkdir_wo_trailing_slash(const char *dir, mode_t mode) size_t len = strlen(dir); if (len && dir[len-1] == '/') { - if ((tmp_dir = strdup(dir)) == NULL) + if (!(tmp_dir = strdup(dir))) return -1; tmp_dir[len-1] = '\0'; } diff --git a/compat/mmap.c b/compat/mmap.c index 8d6c02d4bc..2fe1c7732e 100644 --- a/compat/mmap.c +++ b/compat/mmap.c @@ -13,7 +13,7 @@ void *git_mmap(void *start, size_t length, int prot, int flags, int fd, off_t of } start = malloc(length); - if (start == NULL) { + if (!start) { errno = ENOMEM; return MAP_FAILED; } -- cgit v1.3