From 2c048a3038fd4d94e150fbc1dfd2242325ca7db6 Mon Sep 17 00:00:00 2001 From: Christian Couder Date: Thu, 22 Jul 2010 15:18:29 +0200 Subject: revert: fix off by one read when searching the end of a commit subject A test case is added but the problem can only be seen when running the test case with --valgrind. Signed-off-by: Christian Couder Acked-by: Jonathan Nieder Signed-off-by: Junio C Hamano --- builtin/revert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'builtin') diff --git a/builtin/revert.c b/builtin/revert.c index 7d68ef714e..c170715ba8 100644 --- a/builtin/revert.c +++ b/builtin/revert.c @@ -127,7 +127,7 @@ static int get_message(const char *raw_message, struct commit_message *out) p++; if (*p) { p += 2; - for (eol = p + 1; *eol && *eol != '\n'; eol++) + for (eol = p; *eol && *eol != '\n'; eol++) ; /* do nothing */ } else eol = p; -- cgit v1.3