From 2ad150e35e52705a97f18bee08f34e00a6557d6f Mon Sep 17 00:00:00 2001 From: Sean Allred Date: Sat, 26 Nov 2022 14:17:57 +0000 Subject: var: allow GIT_EDITOR to return null The handling to die early when there is no EDITOR is valuable when used in normal code (i.e., editor.c). In git-var, where null/empty-string is a perfectly valid value to return, it doesn't make as much sense. Remove this handling from `git var GIT_EDITOR` so that it does not fail so noisily when there is no defined editor. Signed-off-by: Sean Allred Signed-off-by: Junio C Hamano --- builtin/var.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'builtin') diff --git a/builtin/var.c b/builtin/var.c index 5cbe32ec89..a1a2522126 100644 --- a/builtin/var.c +++ b/builtin/var.c @@ -11,12 +11,7 @@ static const char var_usage[] = "git var (-l | )"; static const char *editor(int flag) { - const char *pgm = git_editor(); - - if (!pgm && flag & IDENT_STRICT) - die("Terminal is dumb, but EDITOR unset"); - - return pgm; + return git_editor(); } static const char *pager(int flag) -- cgit v1.3