From 3f0cdfa87907096ed7c6caa33fbf360e0e19844c Mon Sep 17 00:00:00 2001 From: Jonatan Holmgren Date: Wed, 18 Feb 2026 22:57:34 +0100 Subject: help: use list_aliases() for alias listing help.c has its own get_alias() config callback that duplicates the parsing logic in alias.c. Consolidate by teaching list_aliases() to also store the alias values (via the string_list util field), then use it in list_all_cmds_help_aliases() instead of the private callback. This preserves the existing error checking for value-less alias definitions by checking in alias.c rather than help.c. No functional change intended. Signed-off-by: Jonatan Holmgren Signed-off-by: Junio C Hamano --- alias.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'alias.c') diff --git a/alias.c b/alias.c index 1a1a141a0a..271acb9bf1 100644 --- a/alias.c +++ b/alias.c @@ -29,7 +29,13 @@ static int config_alias_cb(const char *key, const char *value, key, value); } } else if (data->list) { - string_list_append(data->list, p); + struct string_list_item *item; + + if (!value) + return config_error_nonbool(key); + + item = string_list_append(data->list, p); + item->util = xstrdup(value); } return 0; -- cgit v1.3-5-g9baa