summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2024-12-23 09:32:18 -0800
committerJunio C Hamano <gitster@pobox.com>2024-12-23 09:32:18 -0800
commit77edd59394b3200b672c4cfd50e067ddb6193e2b (patch)
tree7ae766c84004c4d57b5494b53d80ae4fc1179769
parent88e59f8027ed0260584ccc0abd6fe435031614eb (diff)
parent7525cd8c3522827be57915941ebbba859c45ce0b (diff)
downloadgit-77edd59394b3200b672c4cfd50e067ddb6193e2b.tar.xz
Merge branch 'sk/calloc-not-malloc-plus-memset'
Code clean-up. * sk/calloc-not-malloc-plus-memset: git: use calloc instead of malloc + memset where possible
-rw-r--r--remote.c4
-rw-r--r--submodule.c10
2 files changed, 7 insertions, 7 deletions
diff --git a/remote.c b/remote.c
index b80e810a90..18e5ccf391 100644
--- a/remote.c
+++ b/remote.c
@@ -2873,9 +2873,9 @@ void apply_push_cas(struct push_cas_option *cas,
struct remote_state *remote_state_new(void)
{
- struct remote_state *r = xmalloc(sizeof(*r));
+ struct remote_state *r;
- memset(r, 0, sizeof(*r));
+ CALLOC_ARRAY(r, 1);
hashmap_init(&r->remotes_hash, remotes_hash_cmp, NULL, 0);
hashmap_init(&r->branches_hash, branches_hash_cmp, NULL, 0);
diff --git a/submodule.c b/submodule.c
index ed1441923d..b361076c5b 100644
--- a/submodule.c
+++ b/submodule.c
@@ -1490,14 +1490,13 @@ struct fetch_task {
*/
static const struct submodule *get_non_gitmodules_submodule(const char *path)
{
- struct submodule *ret = NULL;
+ struct submodule *ret;
const char *name = default_name_or_path(path);
if (!name)
return NULL;
- ret = xmalloc(sizeof(*ret));
- memset(ret, 0, sizeof(*ret));
+ CALLOC_ARRAY(ret, 1);
ret->path = name;
ret->name = name;
@@ -1537,8 +1536,9 @@ static struct fetch_task *fetch_task_create(struct submodule_parallel_fetch *spf
const char *path,
const struct object_id *treeish_name)
{
- struct fetch_task *task = xmalloc(sizeof(*task));
- memset(task, 0, sizeof(*task));
+ struct fetch_task *task;
+
+ CALLOC_ARRAY(task, 1);
if (validate_submodule_path(path) < 0)
exit(128);