diff options
| author | Junio C Hamano <gitster@pobox.com> | 2022-09-13 12:21:10 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-09-13 12:21:10 -0700 |
| commit | 37317ab40b9fd2458ce48fe10e34bb9d478224a9 (patch) | |
| tree | f331b6845748e0f96dba10652e5225c522020b43 | |
| parent | c61614e30f6df550a5d48fc115fb6a92266ecf50 (diff) | |
| parent | 23578904da8eef802752b48f9a2d4ea9f8a60c59 (diff) | |
| download | git-37317ab40b9fd2458ce48fe10e34bb9d478224a9.tar.xz | |
Merge branch 'ad/preload-plug-memleak' into maint
The preload-index codepath made copies of pathspec to give to
multiple threads, which were left leaked.
* ad/preload-plug-memleak:
preload-index: fix memleak
| -rw-r--r-- | preload-index.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/preload-index.c b/preload-index.c index e5529a5863..100f7a374d 100644 --- a/preload-index.c +++ b/preload-index.c @@ -151,6 +151,12 @@ void preload_index(struct index_state *index, } stop_progress(&pd.progress); + if (pathspec) { + /* earlier we made deep copies for each thread to work with */ + for (i = 0; i < threads; i++) + clear_pathspec(&data[i].pathspec); + } + trace_performance_leave("preload index"); trace2_data_intmax("index", NULL, "preload/sum_lstat", t2_sum_lstat); |
