diff options
| author | Joel Holdsworth <jholdsworth@nvidia.com> | 2021-12-16 13:46:18 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2021-12-16 14:06:36 -0800 |
| commit | 4cf67ae1b6c80eb8a63cc8dd752bd3951cffa104 (patch) | |
| tree | 98d88d4844c59629e61435125acd8845ae1fbcd6 | |
| parent | 9732e2229c9a1f5285109eecef0dddff16be0ace (diff) | |
| download | git-4cf67ae1b6c80eb8a63cc8dd752bd3951cffa104.tar.xz | |
git-p4: open temporary patch file for write only
The patchRCSKeywords method creates a temporary file in which to store
the patched output data. Previously this file was opened in "w+" mode
(write and read), but the code never reads the contents of the file
while open, so it only needs to be opened in "w" mode (write-only).
Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | git-p4.py | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -1754,7 +1754,7 @@ class P4Submit(Command, P4UserMap): # Attempt to zap the RCS keywords in a p4 controlled file matching the given regex (handle, outFileName) = tempfile.mkstemp(dir='.') try: - with os.fdopen(handle, "w+") as outFile, open(file, "r") as inFile: + with os.fdopen(handle, "w") as outFile, open(file, "r") as inFile: for line in inFile.readlines(): outFile.write(regexp.sub(r'$\1$', line)) # Forcibly overwrite the original file |
