From e1993ddbadd8253f1fa65620b209b501ba70e44f Mon Sep 17 00:00:00 2001
From: Shulhan <ms@kilabit.info>
Date: Thu, 1 Nov 2018 00:01:54 +0700
Subject: env: check if new package version is greater than current version

---
 env.go     |  5 +++--
 package.go | 16 ++++++++++++++--
 2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/env.go b/env.go
index d7b35fa..81c13e5 100644
--- a/env.go
+++ b/env.go
@@ -1074,7 +1074,7 @@ func (env *Env) update(curPkg, newPkg *Package) (ok bool, err error) {
 		fmt.Println("[ENV] update >>>", newPkg)
 	}
 
-	if curPkg.IsEqual(newPkg) {
+	if curPkg.IsEqual(newPkg) || !newPkg.IsNewer(curPkg) {
 		fmt.Println("[ENV] update >>> All package is up todate.")
 		ok = true
 		return
@@ -1275,9 +1275,10 @@ func (env *Env) SyncAll() (err error) {
 			return
 		}
 
-		if pkg.Version == pkg.VersionNext {
+		if pkg.Version >= pkg.VersionNext {
 			fmt.Printf("[ENV] SyncAll %s >>> No update.\n\n",
 				pkg.ImportPath)
+			pkg.VersionNext = ""
 			continue
 		}
 
diff --git a/package.go b/package.go
index 56521cc..8b27e54 100644
--- a/package.go
+++ b/package.go
@@ -110,8 +110,8 @@ func (pkg *Package) CompareVersion(newPkg *Package) (err error) {
 }
 
 //
-// FetchLatestVersion will try to update the package and get the latest version (tag or
-// commit).
+// FetchLatestVersion will try to update the package and get the latest
+// version (tag or commit).
 //
 func (pkg *Package) FetchLatestVersion() (err error) {
 	switch pkg.vcsMode {
@@ -209,6 +209,18 @@ func (pkg *Package) IsEqual(other *Package) bool {
 	return true
 }
 
+//
+// IsNewer will return true if current package is using tag and have newer
+// version that other package.  If current package is not using tag, it's
+// always return true.
+//
+func (pkg *Package) IsNewer(older *Package) bool {
+	if !pkg.isTag {
+		return true
+	}
+	return pkg.Version >= older.Version
+}
+
 //
 // Remove package installed binaries, archives, and source.
 //
-- 
cgit v1.3