Collections of packages and tools for working with Go programming language. http://git.kilabit.info/pakakeh.go/atom?h=v0.41.2 2022-10-10T09:02:15Z 2022-10-10T09:02:15Z Shulhan ms@kilabit.info 2022-10-10T09:02:15Z urn:sha1:90e7dffb1349fdaa1cc883bc8d97e2067f21a3be === Bug fixes * lib/websocket: check for EAGAIN and EINTR when reading raw socket * lib/websocket: fix possible data race on Client === Enhancements * lib/websocket: cleanup the channel gracefulClose during Close === Chores * lib/websocket: replace handleInvalidData and BadRequest with sendClose * lib/websocket: rewords some comment and package documentation 2022-10-09T17:48:56Z Shulhan ms@kilabit.info 2022-10-09T17:48:40Z urn:sha1:1465d832f247cf0c94357810c7d958ed165b554f When calling Close, we initialize the internal channel gracefulClose so the client can check the close response from server on another goroutine serve() and signal back to Close to continue the closing process. This channel is never closed and nil-ed again after Close which may cause resource leaks. While at it, use sendClose to minimize duplicate code. 2022-10-09T17:48:56Z Shulhan ms@kilabit.info 2022-10-09T17:38:23Z urn:sha1:5421759721b8da41db483661a6b1bdf175119bed This fix tests that sometimes fail when running with -count=X, where X > 1, $ go test -race -count=30 -timeout=30s ./lib/websocket Upon inspecting, when client sending larger payload, for example 65536 bytes, server sometimes only read half of them and return an error "resource temporarily unavailable" or "interrupted system call". 2022-10-09T17:48:56Z Shulhan ms@kilabit.info 2022-10-08T14:06:25Z urn:sha1:cd0e8e2f30c067c69bd3daa260cc4387143f6059 Both of those functions actually call send control CLOSE frame and not exported. So, instead of duplicating it, we replace it with sendClose. 2022-10-09T17:48:56Z Shulhan ms@kilabit.info 2022-10-08T12:24:17Z urn:sha1:1edecf8f5a09a175cb30bb9939edd8f4497de9a1 The Client have method send that check if the underlying connection (conn) has been closed or not. Since the conn can be closed anytime, for example server send to the control CLOSE frame: recv -> handleFrame -> handleClose -> Quit we need to guard the conn with Mutex before calling send to prevent data race. 2022-10-08T11:51:24Z Shulhan ms@kilabit.info 2022-10-08T11:51:24Z urn:sha1:76df3428683054771930983681721318abfd80d8 2022-10-07T17:04:09Z Shulhan ms@kilabit.info 2022-10-07T17:04:09Z urn:sha1:cc0a706f60941a1c352c38e5900755626f3da3d3 === Enhancements * lib/http: simplify the default user-agent that send by Client * lib/http: support embedded field on UnmarshalForm * lib/test: use text/diff to compare strings on Assert * lib/reflect: remove prefix from returned error on DoEqual * lib/test: change the Assert parameter to Writer === Chores * lib/ini: add example for marshaling slice inside map[string]T * lib/paseto: reformat the documentation * lib/websocket: fix possible race during testing Client * text/diff: rewrite the test again by reading from files 2022-10-04T19:51:35Z Shulhan ms@kilabit.info 2022-10-04T19:51:35Z urn:sha1:5b160b0b0f88748db525e1af89030fa7029f09c7 2022-10-04T19:51:12Z Shulhan ms@kilabit.info 2022-10-04T19:51:12Z urn:sha1:c2270f4bc01d075b448797543344118768f2fd80 2022-10-04T19:42:41Z Shulhan ms@kilabit.info 2022-10-04T19:42:41Z urn:sha1:00b6c3c97d91139a3f8a3e8e6ed80dbe8b065e92 This changes require all unit tests to use their own client.