go/src/runtime/lfstack_test.go, branch fix-runtime-test-GOMAXPROCS

runtime: align taggable pointers more so we can use low bits for tag

2025-04-24T04:44:50Z

Currently we assume alignment to 8 bytes, so we can steal the low 3 bits. This CL assumes alignment to 512 bytes, so we can steal the low 9 bits. That's 6 extra bits! Aligning to 512 bytes wastes a bit of space but it is not egregious. Most of the objects that we make tagged pointers to are pretty big. Update #49405 Change-Id: I66fc7784ac1be5f12f285de1d7851d5a6871fb75 Reviewed-on: https://go-review.googlesource.com/c/go/+/665815 Reviewed-by: Keith Randall Reviewed-by: Michael Knyszek Auto-Submit: Keith Randall LUCI-TryBot-Result: Go LUCI

runtime: fix conflict between lfstack and checkptr

2022-11-17T23:12:04Z

lfstack does very unsafe things. In particular, it will not work with nodes that live on the heap. In normal use by the runtime, that is the case (it is only used for gc work bufs). But the lfstack test does use heap objects. It goes through some hoops to prevent premature deallocation, but those hoops are not enough to convince -d=checkptr that everything is ok. Instead, allocate the test objects outside the heap, like the runtime does for all of its lfstack usage. Remove the lifetime workaround from the test. Reported in https://groups.google.com/g/golang-nuts/c/psjrUV2ZKyI Change-Id: If611105eab6c823a4d6c105938ce145ed731781d Reviewed-on: https://go-review.googlesource.com/c/go/+/448899 Reviewed-by: Austin Clements Reviewed-by: Keith Randall TryBot-Result: Gopher Robot Run-TryBot: Keith Randall

all: gofmt -w -r 'interface{} -> any' src

2021-12-13T18:45:54Z

And then revert the bootstrap cmd directories and certain testdata. And adjust tests as needed. Not reverting the changes in std that are bootstrapped, because some of those changes would appear in API docs, and we want to use any consistently. Instead, rewrite 'any' to 'interface{}' in cmd/dist for those directories when preparing the bootstrap copy. A few files changed as a result of running gofmt -w not because of interface{} -> any but because they hadn't been updated for the new //go:build lines. Fixes #49884. Change-Id: Ie8045cba995f65bd79c694ec77a1b3d1fe01bb09 Reviewed-on: https://go-review.googlesource.com/c/go/+/368254 Trust: Russ Cox Run-TryBot: Russ Cox Reviewed-by: Robert Griesemer TryBot-Result: Gopher Robot

all: fix misprints in comments

2015-06-11T14:18:57Z

These were found by grepping the comments from the go code and feeding the output to aspell. Change-Id: Id734d6c8d1938ec3c36bd94a4dbbad577e3ad395 Reviewed-on: https://go-review.googlesource.com/10941 Reviewed-by: Aamir Khan Reviewed-by: Brad Fitzpatrick

runtime: fix TestLFStack on 386

2015-05-11T15:21:54Z

The new(uint64) was moving to the stack, which may not be aligned. Change-Id: Iad070964202001b52029494d43e299fed980f939 Reviewed-on: https://go-review.googlesource.com/9787 Reviewed-by: Brad Fitzpatrick Reviewed-by: David Chase

[dev.garbage] runtime: fix TestLFStack on 386

2014-10-27T19:57:07Z

LGTM=rlh R=rlh, dvyukov CC=golang-codereviews https://golang.org/cl/157430044

build: move package sources from src/pkg to src

2014-09-08T04:08:51Z

Preparation was in CL 134570043. This CL contains only the effect of 'hg mv src/pkg/* src'. For more about the move, see golang.org/s/go14nopkg.