go/src/runtime/debug/stack.go, branch main

all: fix some function names and typos in comment

2024-11-21T22:16:20Z

Change-Id: I07e7c8eaa5bd4bac0d576b2f2f4cd3f81b0b77a4 Reviewed-on: https://go-review.googlesource.com/c/go/+/630055 LUCI-TryBot-Result: Go LUCI Commit-Queue: Ian Lance Taylor Reviewed-by: Ian Lance Taylor Reviewed-by: Russ Cox Auto-Submit: Ian Lance Taylor

runtime/debug: eliminate temporary variadicity from SetCrashOutput

2024-05-16T15:19:04Z

Updates #67182 Change-Id: I33fc8c515f4a9d120262ba30f61aea80ede5e9f8 Reviewed-on: https://go-review.googlesource.com/c/go/+/585420 LUCI-TryBot-Result: Go LUCI Reviewed-by: Austin Clements

runtime/debug: add SetCrashOutput(...CrashOptions) parameter

2024-05-15T21:04:14Z

This is a placeholder for future options (e.g. JSON). The parameter is temporarily variadic to avoid breaking x/telemetry (see CL 585378), but I plan to remove the "..." later this week. Updates #67182 Change-Id: I3f6f39455d852f92902f8e3f007d3093cbe555db Reviewed-on: https://go-review.googlesource.com/c/go/+/585557 LUCI-TryBot-Result: Go LUCI Reviewed-by: Austin Clements

runtime: be careful about crash FD changes during panic

2024-02-22T15:37:30Z

There are two separate cases here: The base case is simple: a concurrent call to SetCrashOutput while panicking will switch the crash FD, which could cause the first half of writes to go to the old FD, and the second half to the new FD. This isn't a correctness problem, but would be annoying to see in practice. Since it is easy to check for, I simply drop any changes if panicking is already in progress. The second case is more important: SetCrashOutput will close the old FD after the new FD is swapped, but writeErrData has no locking around use of the fd, so SetCrashOutput could close the FD out from under writeErrData, causing lost writes. We handle this similarly, by not allowing SetCrashOutput to close the old FD if a panic is in progress, but we have to be more careful about synchronization between writeErrData and setCrashFD to ensure that writeErrData can't observe the old FD while setCrashFD allows close. For #42888. Change-Id: I7270b2cc5ea58a15ba40145b7a96d557acdfe842 Reviewed-on: https://go-review.googlesource.com/c/go/+/559801 Reviewed-by: Alan Donovan Auto-Submit: Michael Pratt Reviewed-by: Michael Knyszek LUCI-TryBot-Result: Go LUCI

runtime/debug: clarify SetCrashOutput dup behavior

2024-02-21T20:35:26Z

SetCrashOutput dup's the input file for safety, but I don't think that the docs are very clear about what the caller can/should do with f. "it does not close the previous file" is particularly confusing, as it does close the previous FD (but not the previous passed os.File). Expand and attempt to clarify the explanation, borrowing wording from net.FileConn, which also dup's the input os.File. For #42888. Change-Id: I1c96d2dce7899e335d8f1cd464d2d9b31aeb4e5e Reviewed-on: https://go-review.googlesource.com/c/go/+/559800 Reviewed-by: Alan Donovan LUCI-TryBot-Result: Go LUCI

runtime/debug: SetCrashOutput sets the FD for fatal panics

2024-01-31T16:50:42Z

This feature makes it possible to record unhandled panics in any goroutine through a watchdog process (e.g. the same application forked+exec'd as a child in a special mode) that can process the panic report, for example by sending it to a crash-reporting system such as Go telemetry or Sentry. Fixes #42888 Change-Id: I5aa7be8f726bbc70fc650540bd1a14ab60c62ecb Reviewed-on: https://go-review.googlesource.com/c/go/+/547978 Reviewed-by: Michael Pratt LUCI-TryBot-Result: Go LUCI Auto-Submit: Alan Donovan Reviewed-by: Russ Cox

runtime: add available godoc link

2023-11-08T16:59:11Z

Change-Id: Ifb4844efddcb0369b0302eeab72394eeaf5c8072 Reviewed-on: https://go-review.googlesource.com/c/go/+/540022 Reviewed-by: Michael Knyszek Auto-Submit: Michael Knyszek Reviewed-by: Heschi Kreinick TryBot-Result: Gopher Robot Run-TryBot: shuang cui LUCI-TryBot-Result: Go LUCI

runtime/debug: more explicit Stack docs

2015-09-16T22:25:11Z

Change-Id: I81a7f22be827519b5290b4acbcba357680cad3c4 Reviewed-on: https://go-review.googlesource.com/14605 Reviewed-by: Rob Pike

runtime/debug: implement Stack using runtime.Stack

2015-09-16T11:36:21Z

Fixes #12363 Change-Id: I1a025ab6a1cbd5a58f5c2bce5416788387495428 Reviewed-on: https://go-review.googlesource.com/14604 Reviewed-by: Ian Lance Taylor Run-TryBot: David Crawshaw TryBot-Result: Gobot Gobot

all: switch to the new deprecation convention

2015-06-18T19:16:23Z

While we're at it, move some misplaced comment blocks around. Change-Id: I1847d7f1ca1dbb8e5de737203c4ed6c66e112508 Reviewed-on: https://go-review.googlesource.com/10188 Reviewed-by: Rob Pike Reviewed-by: Russ Cox