Fork of Go programming language with my patches. http://git.kilabit.info/go/atom?h=main 2014-09-08T04:08:51Z 2014-09-08T04:08:51Z Russ Cox rsc@golang.org 2014-09-08T04:08:51Z urn:sha1:c007ce824d9a4fccb148f9204e04c23ed2984b71 Preparation was in CL 134570043. This CL contains only the effect of 'hg mv src/pkg/* src'. For more about the move, see golang.org/s/go14nopkg. 2014-09-08T04:06:45Z Russ Cox rsc@golang.org 2014-09-08T04:06:45Z urn:sha1:220a6de47eced55956eb8af8d643d4f5b67fd634 This CL adjusts code referring to src/pkg to refer to src. Immediately after submitting this CL, I will submit a change doing 'hg mv src/pkg/* src'. That change will be too large to review with Rietveld but will contain only the 'hg mv'. This CL will break the build. The followup 'hg mv' will fix it. For more about the move, see golang.org/s/go14nopkg. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/134570043 2013-02-19T15:02:01Z Robin Eklind r.eklind.87@gmail.com 2013-02-19T15:02:01Z urn:sha1:d137a2cb564c50ba104b5699c2a34ad393976564 If a test can be placed in the same package ("internal"), it is placed there. This facilitates testing of package-private details. Because of dependency cycles some packages cannot be tested by internal tests. R=golang-dev, rsc, mikioh.mikioh CC=golang-dev, r https://golang.org/cl/7323044 2013-02-04T05:00:55Z Russ Cox rsc@golang.org 2013-02-04T05:00:55Z urn:sha1:472354f81e6c413508b3f2f43c0f321c4500bacd Fixes #4090. R=golang-dev, iant, bradfitz, dsymonds CC=golang-dev https://golang.org/cl/7229070 2012-10-10T16:49:18Z Dmitriy Vyukov dvyukov@google.com 2012-10-10T16:49:18Z urn:sha1:be2b95fe3a296803cf8cecde14c4123e04f1aa2d If source are not available, then the stack looks like: stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:15 (0x43fb11) stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:18 (0x43fb7a) stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:37 (0x43fbf4) stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/testing/bla-bla-bla/src/pkg/testing/testing.go:301 (0x43b5ba) stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/bla-bla-bla/src/pkg/runtime/proc.c:276 (0x410670) stack_test.go:40: which is 6 lines. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/6637060 2012-03-05T21:13:15Z Russ Cox rsc@golang.org 2012-03-05T21:13:15Z urn:sha1:c0a842e57f38b632ae492174519851036979c988 This happens with GOROOT_FINAL=/somewhere/else R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5727069 2012-02-14T04:05:19Z Russ Cox rsc@golang.org 2012-02-14T04:05:19Z urn:sha1:0995aba983f1c1793c2039d259a8605285d32be6 TBR=r CC=golang-dev https://golang.org/cl/5661053 2012-02-14T03:53:30Z Rob Pike r@golang.org 2012-02-14T03:53:30Z urn:sha1:bf2838334c76312bb65c95e6cbdfa1d40c8e4074 It's not as pretty, but it deletes some irrelevant information from the printout and avoids a dependency. It also means the test binary will stop if a test panics. That's a feature, not a bug. Any output printed by the test appears before the panic traceback. before: --- FAIL: TestPanic (0.00 seconds) fmt_test.go:19: HI testing.go:257: runtime error: index out of range /Users/r/go/src/pkg/testing/testing.go:257 (0x23998) _func_003: t.Logf("%s\n%s", err, debug.Stack()) /Users/r/go/src/pkg/runtime/proc.c:1388 (0x10d2d) panic: reflect·call(d->fn, d->args, d->siz); /Users/r/go/src/pkg/runtime/runtime.c:128 (0x119b0) panicstring: runtime·panic(err); /Users/r/go/src/pkg/runtime/runtime.c:85 (0x11857) panicindex: runtime·panicstring("index out of range"); /Users/r/go/src/pkg/fmt/fmt_test.go:21 (0x23d72) TestPanic: a[10]=1 /Users/r/go/src/pkg/testing/testing.go:264 (0x21b75) tRunner: test.F(t) /Users/r/go/src/pkg/runtime/proc.c:258 (0xee9e) goexit: runtime·goexit(void) FAIL after: --- FAIL: TestPanic (0.00 seconds) fmt_test.go:19: HI panic: runtime error: index out of range [recovered] panic: (*testing.T) (0xec3b0,0xf8400001c0) goroutine 2 [running]: testing._func_003(0x21f5fa8, 0x21f5100, 0x21f5fb8, 0x21f5e88) /Users/r/go/src/pkg/testing/testing.go:259 +0x108 ----- stack segment boundary ----- fmt_test.TestPanic(0xf8400001c0, 0x27603728) /Users/r/go/src/pkg/fmt/fmt_test.go:21 +0x6b testing.tRunner(0xf8400001c0, 0x18edb8, 0x0, 0x0) /Users/r/go/src/pkg/testing/testing.go:264 +0x6f created by testing.RunTests /Users/r/go/src/pkg/testing/testing.go:343 +0x76e goroutine 1 [chan receive]: testing.RunTests(0x2000, 0x18edb8, 0x2400000024, 0x100000001, 0x200000001, ...) /Users/r/go/src/pkg/testing/testing.go:344 +0x791 testing.Main(0x2000, 0x18edb8, 0x2400000024, 0x188a58, 0x800000008, ...) /Users/r/go/src/pkg/testing/testing.go:275 +0x62 main.main() /var/folders/++/+++Fn+++6+0++4RjPqRgNE++2Qk/-Tmp-/go-build743922747/fmt/_test/_testmain.go:129 +0x91 exit status 2 R=rsc, dsymonds CC=golang-dev https://golang.org/cl/5658048 2012-02-13T04:39:40Z Russ Cox rsc@golang.org 2012-02-13T04:39:40Z urn:sha1:f735d2d9d3d9665d0e5058615ac6f62e2ba79887 Among other things, this avoids putting a testing.go:nnn: prefix on every line of the stack trace. R=golang-dev, r, dsymonds, r CC=golang-dev https://golang.org/cl/5651081 2011-07-27T21:56:13Z Russ Cox rsc@golang.org 2011-07-27T21:56:13Z urn:sha1:1bd4b6371a6ca08dd08a543bda9ffbe5992b52ee Fixes #991. R=ken2 CC=golang-dev https://golang.org/cl/4819049