<feed xmlns='http://www.w3.org/2005/Atom'>
<title>go/src/pkg/os/exec/exec.go, branch main</title>
<subtitle>Fork of Go programming language with my patches.</subtitle>
<id>http://git.kilabit.info/go/atom?h=main</id>
<link rel='self' href='http://git.kilabit.info/go/atom?h=main'/>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/'/>
<updated>2014-09-08T04:08:51Z</updated>
<entry>
<title>build: move package sources from src/pkg to src</title>
<updated>2014-09-08T04:08:51Z</updated>
<author>
<name>Russ Cox</name>
<email>rsc@golang.org</email>
</author>
<published>2014-09-08T04:08:51Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=c007ce824d9a4fccb148f9204e04c23ed2984b71'/>
<id>urn:sha1:c007ce824d9a4fccb148f9204e04c23ed2984b71</id>
<content type='text'>
Preparation was in CL 134570043.
This CL contains only the effect of 'hg mv src/pkg/* src'.
For more about the move, see golang.org/s/go14nopkg.
</content>
</entry>
<entry>
<title>src, misc: applied gofmt -s -w</title>
<updated>2014-07-16T23:29:51Z</updated>
<author>
<name>Robert Griesemer</name>
<email>gri@golang.org</email>
</author>
<published>2014-07-16T23:29:51Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=8a23c0021edad5bbf117b71ee7db32406b0c9a67'/>
<id>urn:sha1:8a23c0021edad5bbf117b71ee7db32406b0c9a67</id>
<content type='text'>
Pending CL 113120043.

LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/112290043
</content>
</entry>
<entry>
<title>os/exec: make TestPipeLookPathLeak more verbose when it fails</title>
<updated>2014-04-16T00:36:25Z</updated>
<author>
<name>Brad Fitzpatrick</name>
<email>bradfitz@golang.org</email>
</author>
<published>2014-04-16T00:36:25Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=fdade68379abdd9706881f4273e5f8cd9c0eb518'/>
<id>urn:sha1:fdade68379abdd9706881f4273e5f8cd9c0eb518</id>
<content type='text'>
Trying to understand the linux-386-387 failures:
http://build.golang.org/log/78a91da173c11e986b4e623527c2d0b746f4e814

Also modernize the closeOnce code with a method value, while I
was looking.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews, iant
https://golang.org/cl/87950044
</content>
</entry>
<entry>
<title>os/exec: always try appropriate command extensions during Cmd.Start on windows</title>
<updated>2014-04-04T05:26:15Z</updated>
<author>
<name>Alex Brainman</name>
<email>alex.brainman@gmail.com</email>
</author>
<published>2014-04-04T05:26:15Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=df8ec65b3abcdc8566176d6dae756273d8641706'/>
<id>urn:sha1:df8ec65b3abcdc8566176d6dae756273d8641706</id>
<content type='text'>
Update #7362
Fixes #7377
Fixes #7570

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://golang.org/cl/83020043
</content>
</entry>
<entry>
<title>os/exec: explicitly mention Cmd.Wait() has to be called eventually</title>
<updated>2014-02-23T20:53:02Z</updated>
<author>
<name>Patrick Mézard</name>
<email>patrick@mezard.eu</email>
</author>
<published>2014-02-23T20:53:02Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=d4b6a198b3b44c8c9617c72ceca9c32ba089b5a8'/>
<id>urn:sha1:d4b6a198b3b44c8c9617c72ceca9c32ba089b5a8</id>
<content type='text'>
LGTM=minux.ma, r
R=golang-codereviews, minux.ma, r
CC=golang-codereviews
https://golang.org/cl/67280043
</content>
</entry>
<entry>
<title>os/exec: use filepath.Base in Command</title>
<updated>2014-02-07T01:30:30Z</updated>
<author>
<name>Alex Brainman</name>
<email>alex.brainman@gmail.com</email>
</author>
<published>2014-02-07T01:30:30Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=aac872e11806b7a66ab51f5efab7496a36e4f3da'/>
<id>urn:sha1:aac872e11806b7a66ab51f5efab7496a36e4f3da</id>
<content type='text'>
filepath.Base covers all scenarios
(for example paths like d:hello.txt)
on windows

LGTM=iant, bradfitz
R=golang-codereviews, iant, bradfitz
CC=golang-codereviews
https://golang.org/cl/59740050
</content>
</entry>
<entry>
<title>os/exec: fix Command with relative paths</title>
<updated>2014-02-03T21:32:13Z</updated>
<author>
<name>Brad Fitzpatrick</name>
<email>bradfitz@golang.org</email>
</author>
<published>2014-02-03T21:32:13Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=e6d8bfe218a5f387d7aceddcaee5067a59181838'/>
<id>urn:sha1:e6d8bfe218a5f387d7aceddcaee5067a59181838</id>
<content type='text'>
Command was (and is) documented like:
"If name contains no path separators, Command uses LookPath to
resolve the path to a complete name if possible. Otherwise it
uses name directly."

But that wasn't true. It always did LookPath, and then
set a sticky error that the user couldn't unset.
And then if cmd.Dir was changed, Start would still fail
due to the earlier sticky error being set.

This keeps LookPath in the same place as before (so no user
visible changes in cmd.Path after Command), but only does
it when the documentation says it will happen.

Also, clarify the docs about a relative Dir path.

No change in any existing behavior, except using Command
is now possible with relative paths. Previously it only
worked if you built the *Cmd by hand.

Fixes #7228

LGTM=iant
R=iant
CC=adg, golang-codereviews
https://golang.org/cl/59580044
</content>
</entry>
<entry>
<title>os/exec: add more caveats to StdoutPipe, StderrPipe</title>
<updated>2013-09-13T19:43:54Z</updated>
<author>
<name>Russ Cox</name>
<email>rsc@golang.org</email>
</author>
<published>2013-09-13T19:43:54Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=22e8f82e8d4b62a4c96a82d4f731606a87db8d09'/>
<id>urn:sha1:22e8f82e8d4b62a4c96a82d4f731606a87db8d09</id>
<content type='text'>
(StdinPipe was taken care of by CL 13329043.)

Fixes #6008.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/13606046
</content>
</entry>
<entry>
<title>os/exec: return idempotent Closer from StdinPipe</title>
<updated>2013-08-29T04:41:44Z</updated>
<author>
<name>Andrew Gerrand</name>
<email>adg@golang.org</email>
</author>
<published>2013-08-29T04:41:44Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=10e2ffdf2ca657567fc1708f6387fef69a8445b6'/>
<id>urn:sha1:10e2ffdf2ca657567fc1708f6387fef69a8445b6</id>
<content type='text'>
Before this fix, it was always an error to use the Close method on the
io.WriteCloser obtained from Cmd.StdinPipe, as it would race with the
Close performed by Cmd.Wait.

Fixes #6270.

R=golang-dev, r, remyoudompheng, bradfitz, dsymonds
CC=golang-dev
https://golang.org/cl/13329043
</content>
</entry>
<entry>
<title>os/exec: fix fd leak with Std*Pipe + LookPath</title>
<updated>2013-03-18T16:52:39Z</updated>
<author>
<name>Brad Fitzpatrick</name>
<email>bradfitz@golang.org</email>
</author>
<published>2013-03-18T16:52:39Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=9db0583007e1f644b16d957c2e567ad5e5922338'/>
<id>urn:sha1:9db0583007e1f644b16d957c2e567ad5e5922338</id>
<content type='text'>
If LookPath in Command fails, sets a sticky error, and then
StdinPipe, StdoutPipe, or StderrPipe were called, those pipe
fds were never cleaned up.

Fixes #5071

R=golang-dev, rogpeppe
CC=golang-dev
https://golang.org/cl/7799046
</content>
</entry>
</feed>
