Fork of Go programming language with my patches. http://git.kilabit.info/go/atom?h=go1.3beta2 2014-04-29T16:44:40Z 2014-04-29T16:44:40Z Robert Hencke robert.hencke@gmail.com 2014-04-29T16:44:40Z urn:sha1:f999e14f025b69516dd3e126d04dd309adb2fce0 LGTM=ruiu, bradfitz R=golang-codereviews, bradfitz, ruiu CC=golang-codereviews https://golang.org/cl/91840044 2013-12-26T19:27:18Z Marko Tiikkaja marko@joh.to 2013-12-26T19:27:18Z urn:sha1:0d12e24ebb037202c3324c230e075f1e448f6f34 The last connection in the pool was not being handed out correctly. R=golang-codereviews, gobot, bradfitz CC=golang-codereviews https://golang.org/cl/40410043 2013-12-17T19:57:30Z Julien Schmidt google@julienschmidt.com 2013-12-17T19:57:30Z urn:sha1:762a9d934eab267418595df7a220eec50919b77d This also fixes several connection leaks. Fixes #5718 R=bradfitz, adg CC=alberto.garcia.hierro, golang-dev https://golang.org/cl/14920046 2013-12-16T20:48:35Z Marko Tiikkaja marko@joh.to 2013-12-16T20:48:35Z urn:sha1:1f20ab1116ab6cb0b77e22ffba3de9919e9def50 The previous coding did not correctly check for errors from the driver's Next() or Close(), which could mask genuine errors from the database, as witnessed in issue #6651. Even after this change errors from Close() will be ignored if the query returned no rows (as Rows.Next will have closed the handle already), but it is a lot easier for the drivers to guard against that. Fixes #6651. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/41590043 2013-10-16T16:22:57Z Alberto García Hierro alberto@garciahierro.com 2013-10-16T16:22:57Z urn:sha1:37db8804691f0a5e618cbc041909895c9709263c CL 10726044 introduced a race condition which causes connections to be leaked under certain circumstances. If SetMaxOpenConns is used, the application eventually deadlocks. Otherwise, the number of open connections just keep growing indefinitely. Fixes #6593 R=golang-dev, bradfitz, tad.glines, bketelsen CC=golang-dev https://golang.org/cl/14611045 2013-10-16T16:17:25Z Alberto García Hierro alberto@garciahierro.com 2013-10-16T16:17:25Z urn:sha1:478f4b67543824c039d2f7afec6af88a59148db2 Add a check at the end of every test to make sure there are no leaked connections after running a test. Avoid incorrectly decrementing the number of open connections when the driver connection ends up it a bad state (numOpen was decremented twice). Prevent leaking a Rows struct (which ends up leaking a connection) in Row.Scan() when a *RawBytes destination is improperly used. Close the Rows struct in TestRowsColumns. Update #6593 R=golang-dev, bradfitz, dave CC=golang-dev https://golang.org/cl/14642044 2013-08-30T16:27:33Z Tad Glines tad.glines@gmail.com 2013-08-30T16:27:33Z urn:sha1:41c5d8d85f6c031c591c26404a5009a333d5d974 Update #4805 Add the ability to set an open connection limit. Fixed case where the Conn finalCloser was being called with db.mu locked. Added separate benchmarks for each path for Exec and Query. Replaced slice based idle pool with list based idle pool. R=bradfitz CC=golang-dev https://golang.org/cl/10726044 2013-08-30T00:26:00Z Brad Fitzpatrick bradfitz@golang.org 2013-08-30T00:26:00Z urn:sha1:9456adb36b3731e1e4accadddd7cd2abf5a911b8 Breaks build, and has a race. ««« original CL description database/sql: add SetMaxOpenConns Update #4805 Add the ability to set an open connection limit. Fixed case where the Conn finalCloser was being called with db.mu locked. Added seperate benchmarks for each path for Exec and Query. Replaced slice based idle pool with list based idle pool. R=bradfitz CC=golang-dev https://golang.org/cl/10726044 »»» R=golang-dev CC=golang-dev https://golang.org/cl/13252046 2013-08-30T00:20:39Z Tad Glines tad.glines@gmail.com 2013-08-30T00:20:39Z urn:sha1:4572e4848364b6098b565a2ef480e9b4e8ff5977 Update #4805 Add the ability to set an open connection limit. Fixed case where the Conn finalCloser was being called with db.mu locked. Added seperate benchmarks for each path for Exec and Query. Replaced slice based idle pool with list based idle pool. R=bradfitz CC=golang-dev https://golang.org/cl/10726044 2013-08-16T01:23:35Z Nigel Tao nigeltao@golang.org 2013-08-16T01:23:35Z urn:sha1:bc2126507472e51a6820aecce9f07df6e4231a0a Rows.Close. Previously, callers that followed the example code (but not call rows.Close after "for rows.Next() { ... }") could leak statements if the driver returned an error other than io.EOF. R=bradfitz, alex.brainman CC=golang-dev, rsc https://golang.org/cl/12677050