<feed xmlns='http://www.w3.org/2005/Atom'>
<title>go/src/pkg/database/sql/sql_test.go, branch go1.2</title>
<subtitle>Fork of Go programming language with my patches.</subtitle>
<id>http://git.kilabit.info/go/atom?h=go1.2</id>
<link rel='self' href='http://git.kilabit.info/go/atom?h=go1.2'/>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/'/>
<updated>2013-10-16T16:22:57Z</updated>
<entry>
<title>database/sql: Fix connection leak and potential deadlock</title>
<updated>2013-10-16T16:22:57Z</updated>
<author>
<name>Alberto García Hierro</name>
<email>alberto@garciahierro.com</email>
</author>
<published>2013-10-16T16:22:57Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=37db8804691f0a5e618cbc041909895c9709263c'/>
<id>urn:sha1:37db8804691f0a5e618cbc041909895c9709263c</id>
<content type='text'>
CL 10726044 introduced a race condition which causes connections
to be leaked under certain circumstances. If SetMaxOpenConns is
used, the application eventually deadlocks. Otherwise, the number
of open connections just keep growing indefinitely.

Fixes #6593

R=golang-dev, bradfitz, tad.glines, bketelsen
CC=golang-dev
https://golang.org/cl/14611045
</content>
</entry>
<entry>
<title>database/sql: fix double decrement of numOpen count; test for connection leaks</title>
<updated>2013-10-16T16:17:25Z</updated>
<author>
<name>Alberto García Hierro</name>
<email>alberto@garciahierro.com</email>
</author>
<published>2013-10-16T16:17:25Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=478f4b67543824c039d2f7afec6af88a59148db2'/>
<id>urn:sha1:478f4b67543824c039d2f7afec6af88a59148db2</id>
<content type='text'>
Add a check at the end of every test to make sure
there are no leaked connections after running a test.

Avoid incorrectly decrementing the number of open connections
when the driver connection ends up it a bad state (numOpen was
decremented twice).

Prevent leaking a Rows struct (which ends up leaking a
connection) in Row.Scan() when a *RawBytes destination is
improperly used.

Close the Rows struct in TestRowsColumns.

Update #6593

R=golang-dev, bradfitz, dave
CC=golang-dev
https://golang.org/cl/14642044
</content>
</entry>
<entry>
<title>database/sql: add SetMaxOpenConns</title>
<updated>2013-08-30T16:27:33Z</updated>
<author>
<name>Tad Glines</name>
<email>tad.glines@gmail.com</email>
</author>
<published>2013-08-30T16:27:33Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=41c5d8d85f6c031c591c26404a5009a333d5d974'/>
<id>urn:sha1:41c5d8d85f6c031c591c26404a5009a333d5d974</id>
<content type='text'>
Update #4805

Add the ability to set an open connection limit.
Fixed case where the Conn finalCloser was being called with db.mu locked.
Added separate benchmarks for each path for Exec and Query.
Replaced slice based idle pool with list based idle pool.

R=bradfitz
CC=golang-dev
https://golang.org/cl/10726044
</content>
</entry>
<entry>
<title>undo CL 10726044 / c9bea548fb6f</title>
<updated>2013-08-30T00:26:00Z</updated>
<author>
<name>Brad Fitzpatrick</name>
<email>bradfitz@golang.org</email>
</author>
<published>2013-08-30T00:26:00Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=9456adb36b3731e1e4accadddd7cd2abf5a911b8'/>
<id>urn:sha1:9456adb36b3731e1e4accadddd7cd2abf5a911b8</id>
<content type='text'>
Breaks build, and has a race.

««« original CL description
database/sql: add SetMaxOpenConns

Update #4805

Add the ability to set an open connection limit.
Fixed case where the Conn finalCloser was being called with db.mu locked.
Added seperate benchmarks for each path for Exec and Query.
Replaced slice based idle pool with list based idle pool.

R=bradfitz
CC=golang-dev
https://golang.org/cl/10726044

»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/13252046
</content>
</entry>
<entry>
<title>database/sql: add SetMaxOpenConns</title>
<updated>2013-08-30T00:20:39Z</updated>
<author>
<name>Tad Glines</name>
<email>tad.glines@gmail.com</email>
</author>
<published>2013-08-30T00:20:39Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=4572e4848364b6098b565a2ef480e9b4e8ff5977'/>
<id>urn:sha1:4572e4848364b6098b565a2ef480e9b4e8ff5977</id>
<content type='text'>
Update #4805

Add the ability to set an open connection limit.
Fixed case where the Conn finalCloser was being called with db.mu locked.
Added seperate benchmarks for each path for Exec and Query.
Replaced slice based idle pool with list based idle pool.

R=bradfitz
CC=golang-dev
https://golang.org/cl/10726044
</content>
</entry>
<entry>
<title>database/sql: make Rows.Next returning false always implicitly call</title>
<updated>2013-08-16T01:23:35Z</updated>
<author>
<name>Nigel Tao</name>
<email>nigeltao@golang.org</email>
</author>
<published>2013-08-16T01:23:35Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=bc2126507472e51a6820aecce9f07df6e4231a0a'/>
<id>urn:sha1:bc2126507472e51a6820aecce9f07df6e4231a0a</id>
<content type='text'>
Rows.Close.

Previously, callers that followed the example code (but not call
rows.Close after "for rows.Next() { ... }") could leak statements if
the driver returned an error other than io.EOF.

R=bradfitz, alex.brainman
CC=golang-dev, rsc
https://golang.org/cl/12677050
</content>
</entry>
<entry>
<title>testing: add TB, an interface common to T and B</title>
<updated>2013-08-15T06:21:32Z</updated>
<author>
<name>Brad Fitzpatrick</name>
<email>bradfitz@golang.org</email>
</author>
<published>2013-08-15T06:21:32Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=35d8bb39bd7953dddead3d97db32af77d8941563'/>
<id>urn:sha1:35d8bb39bd7953dddead3d97db32af77d8941563</id>
<content type='text'>
R=golang-dev, kevlar, rsc, adg, r
CC=golang-dev
https://golang.org/cl/12962043
</content>
</entry>
<entry>
<title>database/sql: fix accumulation of bad conns on prepared statements</title>
<updated>2013-08-14T16:27:30Z</updated>
<author>
<name>Matt Joiner</name>
<email>anacrolix@gmail.com</email>
</author>
<published>2013-08-14T16:27:30Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=13c7896fb69cb42da34c31480207aa4e8de19aa5'/>
<id>urn:sha1:13c7896fb69cb42da34c31480207aa4e8de19aa5</id>
<content type='text'>
Fixes an issue where prepared statements that outlive many
connections become expensive to invoke.

Fixes #6081

R=golang-dev
CC=bradfitz, golang-dev
https://golang.org/cl/12646044
</content>
</entry>
<entry>
<title>database/sql: add a disabled broken test</title>
<updated>2013-08-13T21:56:40Z</updated>
<author>
<name>Brad Fitzpatrick</name>
<email>bradfitz@golang.org</email>
</author>
<published>2013-08-13T21:56:40Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=ca3ed9f3520de7998dcc009eca8d35eefec55412'/>
<id>urn:sha1:ca3ed9f3520de7998dcc009eca8d35eefec55412</id>
<content type='text'>
Update #6081

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/12810043
</content>
</entry>
<entry>
<title>database/sql: close statement before connection</title>
<updated>2013-07-23T04:09:53Z</updated>
<author>
<name>Alex Brainman</name>
<email>alex.brainman@gmail.com</email>
</author>
<published>2013-07-23T04:09:53Z</published>
<link rel='alternate' type='text/html' href='http://git.kilabit.info/go/commit/?id=a293065a39963ef2efb4cc133e286d2d97b356a9'/>
<id>urn:sha1:a293065a39963ef2efb4cc133e286d2d97b356a9</id>
<content type='text'>
Fixes #5936

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/11620046
</content>
</entry>
</feed>
